Bug 34441

Summary:	Typo: paramater
Product:	Koha	Reporter:	Katrin Fischer <katrin.fischer>
Component:	Architecture, internals, and plumbing	Assignee:	Pascal Uphaus <pascal.uphaus>
Status:	RESOLVED FIXED	QA Contact:	Testopia <testopia>
Severity:	enhancement
Priority:	P5 - low	CC:	fridolin.somers, pascal.uphaus
Version:	Main	Keywords:	Academy
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Trivial patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	23.11.00
Circulation function:
Attachments:	Bug 34441: Fixed Typo "Paramater" Bug 34441: Fixed Typo "Paramater" Bug 34441: Fixed Typo "Paramater"

Description Katrin Fischer 2023-07-28 11:47:36 UTC

Found this by accident, but we have a few paramaters instead of parameters around:

git grep paramater


catalogue/search.pl:# Fetch the paramater list as a hash in scalar context:
catalogue/search.pl:#  * returns paramater list as tied hash ref
catalogue/search.pl:#  * multivalued CGI paramaters are returned as a packaged string separated by "\0" (null)
opac/opac-search.pl:# Fetch the paramater list as a hash in scalar context:
opac/opac-search.pl:#  * returns paramater list as tied hash ref
opac/opac-search.pl:#  * multivalued CGI paramaters are returned as a packaged string separated by "\0" (null)
tools/cleanborrowers.pl:# Fetch the paramater list as a hash in scalar context:
tools/cleanborrowers.pl:#  * returns paramater list as tied hash ref
tools/cleanborrowers.pl:#  * multivalued CGI paramaters are returned as a packaged string separated by "\0" (null)

Comment 1 Pascal Uphaus 2023-08-17 11:37:57 UTC

Created attachment 154546 [details] [review]
Bug 34441: Fixed Typo "Paramater"

To test:
1. git grep paramater
2. notice 3 files have spelling mistakes
3. apply the patch
4. git grep paramater
5. notice there are no spelling mistakes for that word

Comment 2 Thomas Klausner 2023-08-17 11:47:18 UTC

Created attachment 154548 [details] [review]
Bug 34441: Fixed Typo "Paramater"

To test:
1. git grep paramater
2. notice 3 files have spelling mistakes
3. apply the patch
4. git grep paramater
5. notice there are no spelling mistakes for that word

Signed-off-by: Thomas Klausner <domm@plix.at>

Comment 3 Jonathan Druart 2023-09-01 09:07:24 UTC

Created attachment 155071 [details] [review]
Bug 34441: Fixed Typo "Paramater"

To test:
1. git grep paramater
2. notice 3 files have spelling mistakes
3. apply the patch
4. git grep paramater
5. notice there are no spelling mistakes for that word

Signed-off-by: Thomas Klausner <domm@plix.at>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Comment 4 Tomás Cohen Arazi (tcohen) 2023-09-01 14:24:57 UTC

Pushed to master for 23.11.

Nice work everyone, thanks!

Comment 5 Fridolin Somers 2023-09-08 05:51:09 UTC

Not backported to 23.05.x