| Summary: | Typo: Can be guarantee | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
| Component: | Templates | Assignee: | Laura Escamilla <Laura.escamilla> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | fridolin.somers, Laura.escamilla |
| Version: | Main | Keywords: | Academy |
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.11.00,23.05.05,22.11.11
|
|
| Circulation function: | |||
| Attachments: |
Bug 34446: Added missing colon to Can be guarantee
Bug 34446: Added missing colon to Can be guarantee Bug 34446: (QA follow-up) Add colons on delete confirm page |
||
|
Description
Katrin Fischer
2023-07-31 09:51:18 UTC
Created attachment 156012 [details] [review] Bug 34446: Added missing colon to Can be guarantee To test: 1. Go to Administration > patron categories and edit or create a new category. Notice that “Can be guarantee” does not have a colon. 2. Apply patch and refresh the page. 3. Can be guarantee now has a colon — yay! 4. Sign off and have a great day. :) Hi Laura, your patch is missing the nice test plan you wrote - I believe you might have added it in the 'git bz attach' patch. This only adds it to bugzilla, but not to your patch file. You need to add it with "git commit". Created attachment 156021 [details] [review] Bug 34446: Added missing colon to Can be guarantee To test: 1. Go to Administration > patron categories and edit or create a new category. Notice that “Can be guarantee” does not have a colon. 2. Apply patch and refresh the page. 3. Can be guarantee now has a colon — yay! 4. Sign off and have a great day. :) Created attachment 156022 [details] [review] Bug 34446: (QA follow-up) Add colons on delete confirm page This adds the missing colon on the 'confirm deletion' page. Using my super powers :) - PQA (In reply to Katrin Fischer from comment #2) > Hi Laura, your patch is missing the nice test plan you wrote - I believe you > might have added it in the 'git bz attach' patch. This only adds it to > bugzilla, but not to your patch file. You need to add it with "git commit". I'll make sure to do that next time. Thank you, Katrin! Pushed to master for 23.11. Nice work everyone, thanks! Pushed to 23.05.x for 23.05.05 Nice work everyone! Pushed to oldstable for 22.11.x |