Bug 34447

Summary: "Actions" columns are exported
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: ERMAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P5 - low CC: fridolin.somers, jonathan.druart, jonathan.field, martin.renvoize, matt.blenkinsop, pedro.amorim, tomascohen
Version: unspecified   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34465
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.03,22.11.09
Circulation function:
Attachments: Bue 34447: Do not export "Actions" columns
Bue 34447: Do not export "Actions" columns
Bue 34447: Do not export "Actions" columns

Description Jonathan Druart 2023-07-31 11:23:28 UTC
In the KohaTable Vue component we should add the noExport class to the actions columns to not export them.
Comment 1 Jonathan Druart 2023-07-31 11:25:59 UTC
Created attachment 154086 [details] [review]
Bue 34447: Do not export "Actions" columns

In the KohaTable Vue component we should add the noExport class to the actions columns to not export them.

Test plan:
Go to the ERM module, create at least one agreement.
Go to the agreement list view and click "export" to export the table
=> Without this patch the "Actions" column was exported
=> With this patch is no longer there

Sponsored-by: BULAC - http://www.bulac.fr/
Comment 2 Sam Lau 2023-07-31 14:55:28 UTC
Created attachment 154096 [details] [review]
Bue 34447: Do not export "Actions" columns

In the KohaTable Vue component we should add the noExport class to the actions columns to not export them.

Test plan:
Go to the ERM module, create at least one agreement.
Go to the agreement list view and click "export" to export the table
=> Without this patch the "Actions" column was exported
=> With this patch is no longer there

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Sam Lau <samalau@gmail.com>
Comment 3 Pedro Amorim 2023-07-31 15:17:48 UTC
Created attachment 154102 [details] [review]
Bue 34447: Do not export "Actions" columns

In the KohaTable Vue component we should add the noExport class to the actions columns to not export them.

Test plan:
Go to the ERM module, create at least one agreement.
Go to the agreement list view and click "export" to export the table
=> Without this patch the "Actions" column was exported
=> With this patch is no longer there

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Sam Lau <samalau@gmail.com>
Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Comment 4 Tomás Cohen Arazi (tcohen) 2023-08-15 12:16:26 UTC
> Created attachment 154102 [details] [review] [review]
> Bue 34447: Do not export "Actions" columns
    ^

Hey y'all, please don't forget to run the 'qa' script...
Comment 5 Tomás Cohen Arazi (tcohen) 2023-08-15 12:20:20 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 6 Pedro Amorim 2023-08-15 19:41:35 UTC
(In reply to Tomás Cohen Arazi from comment #4)
> > Created attachment 154102 [details] [review] [review] [review]
> > Bue 34447: Do not export "Actions" columns
>     ^
> 
> Hey y'all, please don't forget to run the 'qa' script...

Fair point. Thanks Tomas.
Comment 7 Fridolin Somers 2023-08-17 20:15:56 UTC
Bue pushed to 23.05.x for 23.05.03
;)
Comment 8 Pedro Amorim 2023-08-18 13:51:37 UTC
Nice work everyone!

Pushed to 22.11.x for next release