Bug 34453

Summary: Update background of quick spine label pop-up
Product: Koha Reporter: Caroline Cyr La Rose <caroline.cyr-la-rose>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Katrin Fischer <katrin.fischer>
Severity: enhancement    
Priority: P5 - low CC: fridolin.somers
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00
Circulation function:
Bug Depends on: 34343    
Bug Blocks:    
Attachments: Bug 34453: Update background of quick spine label pop-up
Bug 34453: Update background of quick spine label pop-up
Bug 34453: Update background of quick spine label pop-up
Bug 34453: Update background of quick spine label pop-up

Description Caroline Cyr La Rose 2023-08-01 20:28:00 UTC
When printing a quick spine label, the background of the pop-up window is still in the old style.

To recreate:
0. Make sure to have an item with a call number and a barcode
1. Go to Cataloging > Quick spine label creator
2. Enter the barcode of the item and press Enter
   --> The background of the pop-up is blue
Comment 1 Owen Leonard 2023-08-04 13:37:34 UTC
Created attachment 154277 [details] [review]
Bug 34453: Update background of quick spine label pop-up

This patch updates the quick spine label popup so that the footer uses
the same markup as the recently updated Z39.50 popup window in
cataloging.

To test, apply the patch and rebuild the staff interface CSS.

Go to Cataloging -> Quick spine label creator.

 - Test the form with both an existing barcode and a non-existent
   barcode.
   - In the pop-up window, confirm that the footer looks correct and
     that the buttons in the footer, in both cases, work correctly.
Comment 2 Sam Lau 2023-08-04 14:41:15 UTC Comment hidden (obsolete)
Comment 3 Caroline Cyr La Rose 2023-08-07 14:18:21 UTC
Created attachment 154306 [details] [review]
Bug 34453: Update background of quick spine label pop-up

This patch updates the quick spine label popup so that the footer uses
the same markup as the recently updated Z39.50 popup window in
cataloging.

To test, apply the patch and rebuild the staff interface CSS.

Go to Cataloging -> Quick spine label creator.

 - Test the form with both an existing barcode and a non-existent
   barcode.
   - In the pop-up window, confirm that the footer looks correct and
     that the buttons in the footer, in both cases, work correctly.

Signed-off-by: Sam Lau <samalau@gmail.com>
Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Comment 4 Caroline Cyr La Rose 2023-08-07 14:20:23 UTC
Thanks Owen!
Comment 5 Katrin Fischer 2023-09-21 20:48:46 UTC
Created attachment 156010 [details] [review]
Bug 34453: Update background of quick spine label pop-up

This patch updates the quick spine label popup so that the footer uses
the same markup as the recently updated Z39.50 popup window in
cataloging.

To test, apply the patch and rebuild the staff interface CSS.

Go to Cataloging -> Quick spine label creator.

 - Test the form with both an existing barcode and a non-existent
   barcode.
   - In the pop-up window, confirm that the footer looks correct and
     that the buttons in the footer, in both cases, work correctly.

Signed-off-by: Sam Lau <samalau@gmail.com>
Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Tomás Cohen Arazi (tcohen) 2023-09-22 14:35:06 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 7 Fridolin Somers 2023-09-22 19:52:47 UTC
Enhancement not pushed to 23.05.x