Bug 34457

Summary: Add card number to hold details page
Product: Koha Reporter: Laura Escamilla <Laura.escamilla>
Component: CirculationAssignee: Laura Escamilla <Laura.escamilla>
Status: CLOSED FIXED QA Contact: Victor Grousset/tuxayo <victor>
Severity: enhancement    
Priority: P5 - low CC: fridolin.somers, gmcharlt, kyle.m.hall, matt.blenkinsop, rcoert, sally.healey, victor
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.05
Circulation function:
Attachments: Bug 34457: Added the patron's cardnumber to the hold details page
Bug 34457: Added the patron's cardnumber to the hold details page
Bug 34457: Added the patron's cardnumber to the hold details page
Bug 34457: Rebased added the patron's cardnumber to the hold details page
Bug 34457: Added cardnumber view to hold details page
Bug 34457: Added cardnumber view to hold details page
Bug 34457: Added cardnumber view to hold details page

Description Laura Escamilla 2023-08-02 13:55:06 UTC
Adding the patron's cardnumber to the Hold details page can help libraries verify whether they are placing the hold for the correct patron. Especially if they have several patrons with the same or similar name. 

/cgi-bin/koha/reserve/request.pl
Comment 1 Laura Escamilla 2023-08-02 14:00:13 UTC
Created attachment 154157 [details] [review]
Bug 34457: Added the patron's cardnumber to the hold details page

Test plan:
1. Go to place a hold on a patron
2. The hold details page (/cgi-bin/koha/reserve/request.pl) only shows the patron’s name. 
3. Apply the patch
4. The hold details page now shows the patron’s name and their card number. 
5. Sign off!
Comment 2 PTFS Europe Sandboxes 2023-08-02 15:14:16 UTC
Created attachment 154161 [details] [review]
Bug 34457: Added the patron's cardnumber to the hold details page

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Comment 3 Sally 2023-08-02 15:15:44 UTC
Really nice idea for a patch - works as expected, signed off.
Comment 4 ByWater Sandboxes 2023-08-02 18:16:56 UTC
Created attachment 154162 [details] [review]
Bug 34457: Added the patron's cardnumber to the hold details page

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Signed-off-by: Christine Lee <chlee@pascolibraries.org>
Comment 5 Owen Leonard 2023-08-03 18:47:09 UTC
There's no need to remove the use of the patron-title include file.

You can remove the "no_cardnumber => 1" from that line and it will work just how you want it to.
Comment 6 Laura Escamilla 2023-08-03 20:07:19 UTC
Created attachment 154234 [details] [review]
Bug 34457: Rebased added the patron's cardnumber to the hold details page

Same test plan as before
Comment 7 Laura Escamilla 2023-08-03 20:07:45 UTC
(In reply to Owen Leonard from comment #5)
> There's no need to remove the use of the patron-title include file.
> 
> You can remove the "no_cardnumber => 1" from that line and it will work just
> how you want it to.

Thank you, Owen.
Comment 8 Laura Escamilla 2023-08-04 17:31:17 UTC
Created attachment 154295 [details] [review]
Bug 34457: Added cardnumber view to hold details page

Test plan:
1. Go to place a hold on a patron
2. The hold details page (/cgi-bin/koha/reserve/request.pl) only shows the patron’s name. 
3. Apply the patch
4. The hold details page now shows the patron’s name and their card number. 
5. Sign off!
Comment 9 ByWater Sandboxes 2023-08-11 19:02:48 UTC
Created attachment 154387 [details] [review]
Bug 34457: Added cardnumber view to hold details page

Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us>
Comment 10 Rebecca Coert 2023-08-11 20:24:00 UTC
Works as described!
Comment 11 Victor Grousset/tuxayo 2023-10-07 17:51:02 UTC
Created attachment 156691 [details] [review]
Bug 34457: Added cardnumber view to hold details page

Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Comment 12 Victor Grousset/tuxayo 2023-10-07 17:56:04 UTC
Works, makes sense, QA script happy, code looks good, passing QA :)

(tested with a long name and long card number, page layout is still good)

@Laura it seem the test plan was put in the bugzilla comment when attaching the commit. It works better to put it in the commit message directly. That way a signoff doesn't cause the test plan to be lost.
Comment 13 Tomás Cohen Arazi (tcohen) 2023-10-09 14:43:08 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 14 Fridolin Somers 2023-10-09 18:45:08 UTC
Very useful, I choose to backport.

Pushed to 23.05.x for 23.05.05
Comment 15 Matt Blenkinsop 2023-10-17 17:28:17 UTC
Enhancement - not backporting to 22.11.x