Summary: | "Clear filter" always disabled | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | ERM | Assignee: | Pedro Amorim <pedro.amorim> |
Status: | RESOLVED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers, jonathan.druart, jonathan.field, martin.renvoize, matt.blenkinsop, pedro.amorim |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38071 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.11.00,23.05.04,22.11.10
|
|
Circulation function: | |||
Attachments: |
Bug 34466: Add listener to enable or disable clear filter button on KohaTable.vue
Bug 34466: Cypress tests Bug 34466: Add listener to enable or disable clear filter button on KohaTable.vue Bug 34466: Cypress tests Bug 34466: Add listener to enable or disable clear filter button on KohaTable.vue |
Description
Jonathan Druart
2023-08-03 07:30:12 UTC
Created attachment 154799 [details] [review] Bug 34466: Add listener to enable or disable clear filter button on KohaTable.vue Pedro, shouldn't we provide Cypress tests? I think we should reuse the code from js/datatables.js instead, like we do for _dt_visibility, _dt_buttons, _dt_default_ajax, etc. Created attachment 155020 [details] [review] Bug 34466: Cypress tests Created attachment 155021 [details] [review] Bug 34466: Add listener to enable or disable clear filter button on KohaTable.vue Test plan: Apply only the cypress test patch Run KohaTable_spec.ts Notice it fails Apply this patch, repeat Thanks Jonathan I wasn't aware the code be reused directly (doh!) Created attachment 155064 [details] [review] Bug 34466: Cypress tests Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 155065 [details] [review] Bug 34466: Add listener to enable or disable clear filter button on KohaTable.vue Test plan: Apply only the cypress test patch Run KohaTable_spec.ts Notice it fails Apply this patch, repeat Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 23.11. Nice work everyone, thanks! Pushed to 23.05.x for 23.05.04 Nice work everyone! Pushed to oldstable for 22.11.x |