Bug 34486

Summary: Hide more OPAC holdings table columns when they are empty
Product: Koha Reporter: Michaela Sieber <michaela.sieber>
Component: OPACAssignee: Owen Leonard <oleonard>
Status: Pushed to main --- QA Contact: Paul Derscheid <me>
Severity: enhancement    
Priority: P5 - low    
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00
Circulation function:
Attachments: Bug 34486: Show OPAC Column Due Date only if items on loan exist
Bug 34486: Show OPAC Column Due Date only if items on loan exist
Bug 34486: Show OPAC Column Due Date only if items on loan exist
Bug 34486: (QA follow-up) Tidy changes to opac/opac-detail.pl

Description Michaela Sieber 2023-08-06 12:09:02 UTC
The OPAC holdings table always has a column for Due Date even if all items are available or all items are not for loan.


The Column Due Date should only appear if items on loan exist.
Comment 1 Owen Leonard 2024-08-05 14:51:17 UTC
Created attachment 170068 [details] [review]
Bug 34486: Show OPAC Column Due Date only if items on loan exist

This patch updates the OPAC bibliographic detail page so that in the
holdings table, the following columns are hidden if they contain no
data: Call number, date due, materials, checkouts, barcode,
and item-level holds.

To test, apply the patch and restart services.

- In the staff interface, go to Administration -> System preferences.
- Search for OPACShowHoldQueueDetails and set it to "Show holds and
  their priority level."
- Search for OPACShowHoldQueueDetails and set it to "Show holds and
  their priority level."
- In the OPAC, locate a bibliographic record with multiple items.
- View the detail page and confirm that the holdings table doesn't show
  these columns if there is no data in any of the rows: Call number,
  date due, materials, barcode, and item-level holds
- For each of the affected fields, update the record the record so that
  there is data to be shown for at least one of the items:
  - Edit an item to add: call number, materials specified, barcode
  - Check out an item to someone in order to show the date due column
  - Place an item-level hold on one of the items to show the item holds
    column.
- Go to Administration -> Table settings -> OPAC -> biblio-detail and
  configure some columns to be hidden by default. Confirm that your
  changes are correctly shown in the OPAC holdings table.

Sponsored-by: Athens County Public Libraries
Comment 2 PTFS Europe Sandboxes 2024-08-05 15:39:07 UTC
Created attachment 170073 [details] [review]
Bug 34486: Show OPAC Column Due Date only if items on loan exist

This patch updates the OPAC bibliographic detail page so that in the
holdings table, the following columns are hidden if they contain no
data: Call number, date due, materials, checkouts, barcode,
and item-level holds.

To test, apply the patch and restart services.

- In the staff interface, go to Administration -> System preferences.
- Search for OPACShowHoldQueueDetails and set it to "Show holds and
  their priority level."
- Search for OPACShowHoldQueueDetails and set it to "Show holds and
  their priority level."
- In the OPAC, locate a bibliographic record with multiple items.
- View the detail page and confirm that the holdings table doesn't show
  these columns if there is no data in any of the rows: Call number,
  date due, materials, barcode, and item-level holds
- For each of the affected fields, update the record the record so that
  there is data to be shown for at least one of the items:
  - Edit an item to add: call number, materials specified, barcode
  - Check out an item to someone in order to show the date due column
  - Place an item-level hold on one of the items to show the item holds
    column.
- Go to Administration -> Table settings -> OPAC -> biblio-detail and
  configure some columns to be hidden by default. Confirm that your
  changes are correctly shown in the OPAC holdings table.

Sponsored-by: Athens County Public Libraries
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Comment 3 Michaela Sieber 2024-08-05 15:42:04 UTC
Great enhancement, thanks!
Comment 4 Paul Derscheid 2024-08-22 08:37:21 UTC
Created attachment 170587 [details] [review]
Bug 34486: Show OPAC Column Due Date only if items on loan exist

This patch updates the OPAC bibliographic detail page so that in the
holdings table, the following columns are hidden if they contain no
data: Call number, date due, materials, checkouts, barcode,
and item-level holds.

To test, apply the patch and restart services.

- In the staff interface, go to Administration -> System preferences.
- Search for OPACShowHoldQueueDetails and set it to "Show holds and
  their priority level."
- Search for OPACShowHoldQueueDetails and set it to "Show holds and
  their priority level."
- In the OPAC, locate a bibliographic record with multiple items.
- View the detail page and confirm that the holdings table doesn't show
  these columns if there is no data in any of the rows: Call number,
  date due, materials, barcode, and item-level holds
- For each of the affected fields, update the record the record so that
  there is data to be shown for at least one of the items:
  - Edit an item to add: call number, materials specified, barcode
  - Check out an item to someone in order to show the date due column
  - Place an item-level hold on one of the items to show the item holds
    column.
- Go to Administration -> Table settings -> OPAC -> biblio-detail and
  configure some columns to be hidden by default. Confirm that your
  changes are correctly shown in the OPAC holdings table.

Sponsored-by: Athens County Public Libraries
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Comment 5 Paul Derscheid 2024-08-22 08:41:42 UTC
Created attachment 170588 [details] [review]
Bug 34486: (QA follow-up) Tidy changes to opac/opac-detail.pl
Comment 6 Katrin Fischer 2024-08-29 15:38:56 UTC
Fixed QA tool complaint:
 FAIL	t/db_dependent/Koha/Installer.t
   FAIL	  file permissions
		File must have the exec flag
Comment 7 Katrin Fischer 2024-08-29 16:16:54 UTC
Pushed for 24.11!

Well done everyone, thank you!