| Summary: | Cannot create baskets if too many vendors | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | Acquisitions | Assignee: | Nick Clemens (kidclamp) <nick> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | caroline.cyr-la-rose, fridolin.somers, jonathan.druart, lucas, martin.renvoize, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Caroline Cyr La Rose | Documentation submission: | https://gitlab.com/koha-community/koha-manual/-/merge_requests/750 |
| Text to go in the release notes: | Version(s) released in: |
23.11.00,23.05.04,22.11.10
|
|
| Circulation function: | |||
| Attachments: |
Bug 34509: Use select2 to load vendors on basket creation
Bug 34509: Make select2 dropdown populate on change Bug 34509: Use select2 to load vendors on basket creation Bug 34509: Use select2 to load vendors on basket creation Bug 34509: Use select2 to load vendors on basket creation Bug 34509: Use select2 to load vendors on basket creation |
||
|
Description
Nick Clemens (kidclamp)
2023-08-09 17:39:36 UTC
Created attachment 154337 [details] [review] Bug 34509: Use select2 to load vendors on basket creation This patch moves the dropdown to use select2 and avoids loading all vendors at page load. To test: 1 - Create some extra vendors in your system, ideally over 20 2 - Search for a vendor in acquisitions 3 - Click 'New->basket' 4 - Note the dropdown of all vendors 5 - Choose a vendor and create a basket 6 - Apply patch 7 - Repeat 8 - Note only a partial list of vendors is loaded 9 - Search in the dropdown and confirm vendors are returned 10 - Select a vendor and create the basket Something is wrong in my patch though, it won't save the selection, help? Created attachment 154341 [details] [review] Bug 34509: Make select2 dropdown populate on change Created attachment 154732 [details] [review] Bug 34509: Use select2 to load vendors on basket creation This patch moves the dropdown to use select2 and avoids loading all vendors at page load. To test: 1 - Create some extra vendors in your system, ideally over 20 2 - Search for a vendor in acquisitions 3 - Click 'New->basket' 4 - Note the dropdown of all vendors 5 - Choose a vendor and create a basket 6 - Apply patch 7 - Repeat 8 - Note only a partial list of vendors is loaded 9 - Search in the dropdown and confirm vendors are returned 10 - Select a vendor and create the basket Created attachment 154734 [details] [review] Bug 34509: Use select2 to load vendors on basket creation This patch moves the dropdown to use select2 and avoids loading all vendors at page load. To test: 1 - Create some extra vendors in your system, ideally over 20 2 - Search for a vendor in acquisitions 3 - Click 'New->basket' 4 - Note the dropdown of all vendors 5 - Choose a vendor and create a basket 6 - Apply patch 7 - Repeat 8 - Note only a partial list of vendors is loaded 9 - Search in the dropdown and confirm vendors are returned 10 - Select a vendor and create the basket Created attachment 154735 [details] [review] Bug 34509: Use select2 to load vendors on basket creation This patch moves the dropdown to use select2 and avoids loading all vendors at page load. To test: 1 - Create some extra vendors in your system, ideally over 20 2 - Search for a vendor in acquisitions 3 - Click 'New->basket' 4 - Note the dropdown of all vendors 5 - Choose a vendor and create a basket 6 - Apply patch 7 - Repeat 8 - Note only a partial list of vendors is loaded 9 - Search in the dropdown and confirm vendors are returned 10 - Select a vendor and create the basket Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 154741 [details] [review] Bug 34509: Use select2 to load vendors on basket creation This patch moves the dropdown to use select2 and avoids loading all vendors at page load. To test: 1 - Create some extra vendors in your system, ideally over 20 2 - Search for a vendor in acquisitions 3 - Click 'New->basket' 4 - Note the dropdown of all vendors 5 - Choose a vendor and create a basket 6 - Apply patch 7 - Repeat 8 - Note only a partial list of vendors is loaded 9 - Search in the dropdown and confirm vendors are returned 10 - Select a vendor and create the basket Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Nice improvement, all working as expected. Passing QA Pushed to master for 23.11. Nice work everyone, thanks! Pushed to 23.05.x for 23.05.04 Nice work everyone! Pushed to oldstable for 22.11.x I updated the screenshot in the manual. |