|
Description
Kyle M Hall (khall)
2023-08-14 14:34:09 UTC
Created attachment 154403 [details] [review] Bug 34529: Offline circulation should be able to accept userid as well as cardnumber Like everywhere else in Koha, offline circulation should be able to use userid as well as cardnumber to look up the patron for a transaction ( checkouts and fine payments ). Test Plan: 1) Apply this patch 2) Restart all the things! 3) Download the test.koc file attached to this bug 4) Verify you have an item with the barcode 39999000001396 create it if needed 5) Set a patron's username to "hacevedo" 6) Upload and import the test.koc file into offline circ 7) Verify the item was checked out and the payment was made Created attachment 154411 [details]
test.koc
Created attachment 155969 [details] [review] Bug 34529: Offline circulation should be able to accept userid as well as cardnumber Like everywhere else in Koha, offline circulation should be able to use userid as well as cardnumber to look up the patron for a transaction ( checkouts and fine payments ). Test Plan: 1) Apply this patch 2) Restart all the things! 3) Download the test.koc file attached to this bug 4) Verify you have an item with the barcode 39999000001396 create it if needed 5) Set a patron's username to "hacevedo" 6) Upload and import the test.koc file into offline circ 7) Verify the item was checked out and the payment was made Created attachment 155970 [details] [review] Bug 34529: Offline circulation should be able to accept userid as well as cardnumber Like everywhere else in Koha, offline circulation should be able to use userid as well as cardnumber to look up the patron for a transaction ( checkouts and fine payments ). Test Plan: 1) Apply this patch 2) Restart all the things! 3) Download the test.koc file attached to this bug 4) Verify you have an item with the barcode 39999000001396 create it if needed 5) Set a patron's username to "hacevedo" 6) Upload and import the test.koc file into offline circ 7) Verify the item was checked out and the payment was made Signed-off-by: Philip Orr <philip.orr@lmscloud.de> oops, forgot to signoff before attaching. Sorry! Created attachment 158140 [details] [review] Bug 34529: Offline circulation should be able to accept userid as well as cardnumber Like everywhere else in Koha, offline circulation should be able to use userid as well as cardnumber to look up the patron for a transaction ( checkouts and fine payments ). Test Plan: 1) Apply this patch 2) Restart all the things! 3) Download the test.koc file attached to this bug 4) Verify you have an item with the barcode 39999000001396 create it if needed 5) Set a patron's username to "hacevedo" 6) Upload and import the test.koc file into offline circ 7) Verify the item was checked out and the payment was made Signed-off-by: Philip Orr <philip.orr@lmscloud.de> Created attachment 158141 [details] [review] Bug 34529: (QA follow-up) Update column heading to "Card number or username" Updates the column heading on the table of uploaded transactions to read "Card number or username". Hi Kyle, this looks good so far, but we are missing unit tests for the changes in Circulation. Please also check my small follow-up. Created attachment 158321 [details] [review] Bug 34529: Offline circulation should be able to accept userid as well as cardnumber Like everywhere else in Koha, offline circulation should be able to use userid as well as cardnumber to look up the patron for a transaction ( checkouts and fine payments ). Test Plan: 1) Apply this patch 2) Restart all the things! 3) Download the test.koc file attached to this bug 4) Verify you have an item with the barcode 39999000001396 create it if needed 5) Set a patron's username to "hacevedo" 6) Upload and import the test.koc file into offline circ 7) Verify the item was checked out and the payment was made Signed-off-by: Philip Orr <philip.orr@lmscloud.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 158322 [details] [review] Bug 34529: (QA follow-up) Update column heading to "Card number or username" Updates the column heading on the table of uploaded transactions to read "Card number or username". Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 158323 [details] [review] Bug 34529: (QA follow-up) Add unit tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 158324 [details] [review] Bug 34529: (QA follow-up) Tidy OfflineCirculation.t Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 158380 [details] [review] Bug 34529: Offline circulation should be able to accept userid as well as cardnumber Like everywhere else in Koha, offline circulation should be able to use userid as well as cardnumber to look up the patron for a transaction ( checkouts and fine payments ). Test Plan: 1) Apply this patch 2) Restart all the things! 3) Download the test.koc file attached to this bug 4) Verify you have an item with the barcode 39999000001396 create it if needed 5) Set a patron's username to "hacevedo" 6) Upload and import the test.koc file into offline circ 7) Verify the item was checked out and the payment was made Signed-off-by: Philip Orr <philip.orr@lmscloud.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 158381 [details] [review] Bug 34529: (QA follow-up) Update column heading to "Card number or username" Updates the column heading on the table of uploaded transactions to read "Card number or username". Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 158382 [details] [review] Bug 34529: (QA follow-up) Add unit tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 158383 [details] [review] Bug 34529: (QA follow-up) Tidy OfflineCirculation.t Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.11. Nice work everyone, thanks! Enhancement not pushed to 23.05.x |