Bug 34531

Summary: Hiding Lost card flag and Gone no address flag via BorrowerUnwantedFields hides Patron restrictions
Product: Koha Reporter: Lucas Gass (lukeg) <lucas>
Component: PatronsAssignee: Lucas Gass (lukeg) <lucas>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: barbara.johnson, fridolin.somers, gmcharlt, kyle.m.hall, rcoert
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.05,22.11.12
Circulation function:
Attachments: Bug 34531: Fix template logic to not hide patron restrictions
Bug 34531: Fix template logic to not hide patron restrictions
Bug 34531: Fix template logic to not hide patron restrictions

Description Lucas Gass (lukeg) 2023-08-14 17:56:10 UTC
From BorrowerUnwantedFields
1. Hide Gone no address flag (gonenoaddress) and Lost card flag (lost).
2. Got to memberentrygen.tt and see that Patron restrictions is now hidden
Comment 1 Lucas Gass (lukeg) 2023-10-16 19:46:48 UTC
Created attachment 157212 [details] [review]
Bug 34531: Fix template logic to not hide patron restrictions

To test:
1. From BorrowerUnwantedFields Hide Gone no address flag (gonenoaddress) and Lost card flag (lost).
2. Got to memberentrygen.tt and see that Patron restrictions is now hidden
3. Apply patch, now the Patron restrictions field should not be hidden.
Comment 2 ByWater Sandboxes 2023-10-16 23:35:56 UTC
Created attachment 157220 [details] [review]
Bug 34531: Fix template logic to not hide patron restrictions

To test:
1. From BorrowerUnwantedFields Hide Gone no address flag (gonenoaddress) and Lost card flag (lost).
2. Got to memberentrygen.tt and see that Patron restrictions is now hidden
3. Apply patch, now the Patron restrictions field should not be hidden.

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Comment 3 Chris Cormack 2023-10-17 20:10:48 UTC
Created attachment 157289 [details] [review]
Bug 34531: Fix template logic to not hide patron restrictions

To test:
1. From BorrowerUnwantedFields Hide Gone no address flag (gonenoaddress) and Lost card flag (lost).
2. Got to memberentrygen.tt and see that Patron restrictions is now hidden
3. Apply patch, now the Patron restrictions field should not be hidden.

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Comment 4 Tomás Cohen Arazi (tcohen) 2023-10-19 19:02:17 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 5 Fridolin Somers 2023-10-25 20:58:51 UTC
Pushed to 23.05.x for 23.05.05
Comment 6 Matt Blenkinsop 2023-11-13 14:03:26 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x