|
Description
Nick Clemens (kidclamp)
2023-08-17 08:09:52 UTC
Created attachment 154508 [details] [review] Bug 34557: Add SCOLoadCheckoutsByDefault system preference This patch adds a enw system preference SCOLoadCheckoutsByDefault When enabled, a patron's list o fcurrent checkouts will be loaded when the sign in to the SCO module. If disabled, they will see link to load their checkouts. In either case, a new section is added to the SCO to show a brief display of the last checked out it To test: 1 - Enable WebBasedSelfCheck system preference 2 - Browse to: http://localhost:8080/cgi-bin/koha/sco/sco-main.pl 3 - Sign in the SCO user (or enable AutoSelfCheck) 4 - Sign in as a user with several items checked out 5 - Confirm you see a list of items checked out 6 - Apply patches, updatedatabase, restart_all 7 - 'Finish' and login patron to SCO again 8 - Confirm you still see the list 9 - 'Finish' 10 - Chenge the system preference 11 - Sign in to SCO, confirm checkouts do not load 12 - Confirm you see 'Load your checkouts' link 13 - Check an item out 14 - Confirm you see the last checkout, but not a list 15 - Attempt to checkout an item that cannot be checked out 16 - Confirm "Return to account summary" does not load checkouts 17 - Click "Load your checkouts" 18 - Confirm they load 19 - Check out another item, confrim they remain and are updated 20 - Checkout an item that cannot be issued 21 - Confirm 'Return to account summary' loads the checkouts again Created attachment 154544 [details] [review] Bug 34557: Add SCOLoadCheckoutsByDefault system preference This patch adds a enw system preference SCOLoadCheckoutsByDefault When enabled, a patron's list o fcurrent checkouts will be loaded when the sign in to the SCO module. If disabled, they will see link to load their checkouts. In either case, a new section is added to the SCO to show a brief display of the last checked out it To test: 1 - Enable WebBasedSelfCheck system preference 2 - Browse to: http://localhost:8080/cgi-bin/koha/sco/sco-main.pl 3 - Sign in the SCO user (or enable AutoSelfCheck) 4 - Sign in as a user with several items checked out 5 - Confirm you see a list of items checked out 6 - Apply patches, updatedatabase, restart_all 7 - 'Finish' and login patron to SCO again 8 - Confirm you still see the list 9 - 'Finish' 10 - Chenge the system preference 11 - Sign in to SCO, confirm checkouts do not load 12 - Confirm you see 'Load your checkouts' link 13 - Check an item out 14 - Confirm you see the last checkout, but not a list 15 - Attempt to checkout an item that cannot be checked out 16 - Confirm "Return to account summary" does not load checkouts 17 - Click "Load your checkouts" 18 - Confirm they load 19 - Check out another item, confrim they remain and are updated 20 - Checkout an item that cannot be issued 21 - Confirm 'Return to account summary' loads the checkouts again Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com> Great patch. Only my own incompetence slowed me down in working through the test plan! Created attachment 154587 [details] [review] Bug 34557: (follow-up) Make link more like button in staff interface This patch adds Bootstrap button style to the link and changes the text from "Load your checkouts" to "Show your checkouts." The patch adds an anchor to the link so that the browser jumps down the page a bit making the checkouts more visible. The patch also corrects the includes for Font Awesome files. No icons were loading because of incorrect asset links. To test, follow the previous patch's test plan, checking that the button looks correctly styled and that the page reloads with the checkout form at the top. Confirm that Font Awesome icons are loading throughout the page. Created attachment 154590 [details] [review] Bug 34557: Add SCOLoadCheckoutsByDefault system preference This patch adds a enw system preference SCOLoadCheckoutsByDefault When enabled, a patron's list o fcurrent checkouts will be loaded when the sign in to the SCO module. If disabled, they will see link to load their checkouts. In either case, a new section is added to the SCO to show a brief display of the last checked out it To test: 1 - Enable WebBasedSelfCheck system preference 2 - Browse to: http://localhost:8080/cgi-bin/koha/sco/sco-main.pl 3 - Sign in the SCO user (or enable AutoSelfCheck) 4 - Sign in as a user with several items checked out 5 - Confirm you see a list of items checked out 6 - Apply patches, updatedatabase, restart_all 7 - 'Finish' and login patron to SCO again 8 - Confirm you still see the list 9 - 'Finish' 10 - Chenge the system preference 11 - Sign in to SCO, confirm checkouts do not load 12 - Confirm you see 'Load your checkouts' link 13 - Check an item out 14 - Confirm you see the last checkout, but not a list 15 - Attempt to checkout an item that cannot be checked out 16 - Confirm "Return to account summary" does not load checkouts 17 - Click "Load your checkouts" 18 - Confirm they load 19 - Check out another item, confrim they remain and are updated 20 - Checkout an item that cannot be issued 21 - Confirm 'Return to account summary' loads the checkouts again Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com> Signed-off-by: AndrewA <andrew.auld@ptfs-europe.com> Created attachment 154591 [details] [review] Bug 34557: (follow-up) Make link more like button in staff interface This patch adds Bootstrap button style to the link and changes the text from "Load your checkouts" to "Show your checkouts." The patch adds an anchor to the link so that the browser jumps down the page a bit making the checkouts more visible. The patch also corrects the includes for Font Awesome files. No icons were loading because of incorrect asset links. To test, follow the previous patch's test plan, checking that the button looks correctly styled and that the page reloads with the checkout form at the top. Confirm that Font Awesome icons are loading throughout the page. Signed-off-by: AndrewA <andrew.auld@ptfs-europe.com> Love the button, the anchor and the icons. Great job all! Created attachment 156570 [details] [review] Bug 34557: Add SCOLoadCheckoutsByDefault system preference This patch adds a enw system preference SCOLoadCheckoutsByDefault When enabled, a patron's list o fcurrent checkouts will be loaded when the sign in to the SCO module. If disabled, they will see link to load their checkouts. In either case, a new section is added to the SCO to show a brief display of the last checked out it To test: 1 - Enable WebBasedSelfCheck system preference 2 - Browse to: http://localhost:8080/cgi-bin/koha/sco/sco-main.pl 3 - Sign in the SCO user (or enable AutoSelfCheck) 4 - Sign in as a user with several items checked out 5 - Confirm you see a list of items checked out 6 - Apply patches, updatedatabase, restart_all 7 - 'Finish' and login patron to SCO again 8 - Confirm you still see the list 9 - 'Finish' 10 - Chenge the system preference 11 - Sign in to SCO, confirm checkouts do not load 12 - Confirm you see 'Load your checkouts' link 13 - Check an item out 14 - Confirm you see the last checkout, but not a list 15 - Attempt to checkout an item that cannot be checked out 16 - Confirm "Return to account summary" does not load checkouts 17 - Click "Load your checkouts" 18 - Confirm they load 19 - Check out another item, confrim they remain and are updated 20 - Checkout an item that cannot be issued 21 - Confirm 'Return to account summary' loads the checkouts again Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com> Signed-off-by: AndrewA <andrew.auld@ptfs-europe.com> Created attachment 156571 [details] [review] Bug 34557: (follow-up) Make link more like button in staff interface This patch adds Bootstrap button style to the link and changes the text from "Load your checkouts" to "Show your checkouts." The patch adds an anchor to the link so that the browser jumps down the page a bit making the checkouts more visible. The patch also corrects the includes for Font Awesome files. No icons were loading because of incorrect asset links. To test, follow the previous patch's test plan, checking that the button looks correctly styled and that the page reloads with the checkout form at the top. Confirm that Font Awesome icons are loading throughout the page. Signed-off-by: AndrewA <andrew.auld@ptfs-europe.com> Hi Nick, can you please rebase? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 34557: Add SCOLoadCheckoutsByDefault system preference Applying: Bug 34557: (follow-up) Make link more like button in staff interface error: sha1 information is lacking or useless (koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt). error: could not build fake ancestor Patch failed at 0001 Bug 34557: (follow-up) Make link more like button in staff interface hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-34557-follow-up-Make-link-more-like-button-in--x6buaj81.patch Created attachment 158368 [details] [review] Bug 34557: Add SCOLoadCheckoutsByDefault system preference This patch adds a enw system preference SCOLoadCheckoutsByDefault When enabled, a patron's list o fcurrent checkouts will be loaded when the sign in to the SCO module. If disabled, they will see link to load their checkouts. In either case, a new section is added to the SCO to show a brief display of the last checked out it To test: 1 - Enable WebBasedSelfCheck system preference 2 - Browse to: http://localhost:8080/cgi-bin/koha/sco/sco-main.pl 3 - Sign in the SCO user (or enable AutoSelfCheck) 4 - Sign in as a user with several items checked out 5 - Confirm you see a list of items checked out 6 - Apply patches, updatedatabase, restart_all 7 - 'Finish' and login patron to SCO again 8 - Confirm you still see the list 9 - 'Finish' 10 - Chenge the system preference 11 - Sign in to SCO, confirm checkouts do not load 12 - Confirm you see 'Load your checkouts' link 13 - Check an item out 14 - Confirm you see the last checkout, but not a list 15 - Attempt to checkout an item that cannot be checked out 16 - Confirm "Return to account summary" does not load checkouts 17 - Click "Load your checkouts" 18 - Confirm they load 19 - Check out another item, confrim they remain and are updated 20 - Checkout an item that cannot be issued 21 - Confirm 'Return to account summary' loads the checkouts again Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com> Signed-off-by: AndrewA <andrew.auld@ptfs-europe.com> Created attachment 158369 [details] [review] Bug 34557: (follow-up) Make link more like button in staff interface This patch adds Bootstrap button style to the link and changes the text from "Load your checkouts" to "Show your checkouts." The patch adds an anchor to the link so that the browser jumps down the page a bit making the checkouts more visible. The patch also corrects the includes for Font Awesome files. No icons were loading because of incorrect asset links. To test, follow the previous patch's test plan, checking that the button looks correctly styled and that the page reloads with the checkout form at the top. Confirm that Font Awesome icons are loading throughout the page. Signed-off-by: AndrewA <andrew.auld@ptfs-europe.com> Created attachment 158370 [details] [review] Bug 34557: (follow-up) Tidy Created attachment 158377 [details] [review] Bug 34557: Add SCOLoadCheckoutsByDefault system preference This patch adds a enw system preference SCOLoadCheckoutsByDefault When enabled, a patron's list o fcurrent checkouts will be loaded when the sign in to the SCO module. If disabled, they will see link to load their checkouts. In either case, a new section is added to the SCO to show a brief display of the last checked out it To test: 1 - Enable WebBasedSelfCheck system preference 2 - Browse to: http://localhost:8080/cgi-bin/koha/sco/sco-main.pl 3 - Sign in the SCO user (or enable AutoSelfCheck) 4 - Sign in as a user with several items checked out 5 - Confirm you see a list of items checked out 6 - Apply patches, updatedatabase, restart_all 7 - 'Finish' and login patron to SCO again 8 - Confirm you still see the list 9 - 'Finish' 10 - Chenge the system preference 11 - Sign in to SCO, confirm checkouts do not load 12 - Confirm you see 'Load your checkouts' link 13 - Check an item out 14 - Confirm you see the last checkout, but not a list 15 - Attempt to checkout an item that cannot be checked out 16 - Confirm "Return to account summary" does not load checkouts 17 - Click "Load your checkouts" 18 - Confirm they load 19 - Check out another item, confrim they remain and are updated 20 - Checkout an item that cannot be issued 21 - Confirm 'Return to account summary' loads the checkouts again Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com> Signed-off-by: AndrewA <andrew.auld@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 158378 [details] [review] Bug 34557: (follow-up) Make link more like button in staff interface This patch adds Bootstrap button style to the link and changes the text from "Load your checkouts" to "Show your checkouts." The patch adds an anchor to the link so that the browser jumps down the page a bit making the checkouts more visible. The patch also corrects the includes for Font Awesome files. No icons were loading because of incorrect asset links. To test, follow the previous patch's test plan, checking that the button looks correctly styled and that the page reloads with the checkout form at the top. Confirm that Font Awesome icons are loading throughout the page. Signed-off-by: AndrewA <andrew.auld@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 158379 [details] [review] Bug 34557: (follow-up) Tidy Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.11. Nice work everyone, thanks! Please consider for backport - this is a security and performance issues for libraries using the self check Pushed to 23.05.x for 23.05.06 |