Bug 34565

Summary: Label mismatch in MARC21 006 and 008 cataloging plugins
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Katrin Fischer <katrin.fischer>
Severity: normal    
Priority: P5 - low CC: andrew.auld, fridolin.somers
Version: MainKeywords: Academy, accessibility
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.04,22.11.10
Circulation function:
Attachments: Bug 34565: Label mismatch in MARC21 006 and 008 cataloging plugins
Bug 34565: Label mismatch in MARC21 006 and 008 cataloging plugins
Bug 34565: Label mismatch in MARC21 006 and 008 cataloging plugins

Description Owen Leonard 2023-08-17 11:36:51 UTC
A common JS file, xmlControlfield.js, generates markup for labels and input fields but the labels don't match.
Comment 1 Owen Leonard 2023-08-17 11:46:44 UTC Comment hidden (obsolete)
Comment 2 Biblibre Sandboxes 2023-08-17 12:20:40 UTC
Created attachment 154556 [details] [review]
Bug 34565: Label mismatch in MARC21 006 and 008 cataloging plugins

This patch modifies the JS which builds the table of options for
populating MARC21 fields 006 and 008 when using the cataloging plugin.

To test, apply the patch and go to Cataloging -> New record.

- Click the plugin trigger link next to the 006 input field (you may
  need to click the tag to expand it.
- In the table of input fields, test that clicking the label, e.g. "Type
  of material", "00 - Form of material," etc,  moves focus to the
  corresponding form field.
- Perform the same test on the plugin-popup for field 008.

Signed-off-by: Andrew <andrew.auld@ptfs-europe.com>
Comment 3 Andrew Auld 2023-08-17 12:21:06 UTC
Works beautifully, thanks!
Comment 4 Katrin Fischer 2023-08-24 22:46:51 UTC
Created attachment 154766 [details] [review]
Bug 34565: Label mismatch in MARC21 006 and 008 cataloging plugins

This patch modifies the JS which builds the table of options for
populating MARC21 fields 006 and 008 when using the cataloging plugin.

To test, apply the patch and go to Cataloging -> New record.

- Click the plugin trigger link next to the 006 input field (you may
  need to click the tag to expand it.
- In the table of input fields, test that clicking the label, e.g. "Type
  of material", "00 - Form of material," etc,  moves focus to the
  corresponding form field.
- Perform the same test on the plugin-popup for field 008.

Signed-off-by: Andrew <andrew.auld@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Tomás Cohen Arazi (tcohen) 2023-08-29 17:36:44 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 6 Fridolin Somers 2023-08-30 06:46:08 UTC
Pushed to 23.05.x for 23.05.04
Comment 7 Matt Blenkinsop 2023-08-31 10:12:20 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x