| Summary: | Error 500 is shown when ILL request is not found | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Pedro Amorim <pedro.amorim> |
| Component: | ILL | Assignee: | Pedro Amorim <pedro.amorim> |
| Status: | CLOSED FIXED | QA Contact: | Nick Clemens (kidclamp) <nick> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | fridolin.somers, magnus, martin.renvoize, nick, pedro.amorim, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.11.00
|
|
| Circulation function: | |||
| Attachments: |
Bug 34598: Improve handling of not found ILL request
Bug 34598: Improve handling of not found ILL request Bug 34598: Improve handling of not found ILL request |
||
|
Description
Pedro Amorim
2023-08-23 14:55:39 UTC
Created attachment 154712 [details] [review] Bug 34598: Improve handling of not found ILL request 1) Enable ILLmodule and install FreeForm, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) 2) Visit a request that doesn't exist (assuming empty illrequests table): INTRA/cgi-bin/koha/ill/ill-requests.pl?method=illview&illrequest_id=1 3) Verify an error 500 is returned with message "Can't call method "backend_illview"" 4) Apply patch 5) Repeat steps 1-3. Verify that a "ILL request not found." message is now displayed Created attachment 154733 [details] [review] Bug 34598: Improve handling of not found ILL request 1) Enable ILLmodule and install FreeForm, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) 2) Visit a request that doesn't exist (assuming empty illrequests table): INTRA/cgi-bin/koha/ill/ill-requests.pl?method=illview&illrequest_id=1 3) Verify an error 500 is returned with message "Can't call method "backend_illview"" 4) Apply patch 5) Repeat steps 1-3. Verify that a "ILL request not found." message is now displayed Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 154737 [details] [review] Bug 34598: Improve handling of not found ILL request 1) Enable ILLmodule and install FreeForm, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) 2) Visit a request that doesn't exist (assuming empty illrequests table): INTRA/cgi-bin/koha/ill/ill-requests.pl?method=illview&illrequest_id=1 3) Verify an error 500 is returned with message "Can't call method "backend_illview"" 4) Apply patch 5) Repeat steps 1-3. Verify that a "ILL request not found." message is now displayed Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to master for 23.11. Nice work everyone, thanks! Enhancement not pushed to 23.05.x |