Bug 34619

Summary: Show debug mode column in list of SMTP servers
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Katrin Fischer <katrin.fischer>
Severity: enhancement    
Priority: P5 - low CC: pedro.amorim
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00
Circulation function:
Bug Depends on: 34408    
Bug Blocks:    
Attachments: Bug 34619: Show debug mode column in list of SMTP servers
Bug 34619: Show debug mode column in list of SMTP servers
Bug 34619: Show debug mode column in list of SMTP servers

Description Owen Leonard 2023-08-25 15:44:26 UTC
On the SMTP server page we indicate that a server has debug mode enabled by changing the color of the text in the row, but that doesn't naturally convey any meaning. I think it would be good to add a column showing whether debug mode is on or off.
Comment 1 Owen Leonard 2023-08-28 12:59:04 UTC
Created attachment 154884 [details] [review]
Bug 34619: Show debug mode column in list of SMTP servers

This patch adds a column to the table of SMTP servers which shows
whether debug mode is on or off. This information was previously only
conveyed through the color of the text in the table row.

To test, apply the patch and go to Administration -> SMTP servers.

- If necessary, add one or more SMTP servers so that there are more than
  one: At least one with debug mode on, at least one with debug mode
  off.
- In the table listing SMTP servers you should see a column for "Debug
  mode," where the rows indicate "On" or "Off."
- Each row which is highlighted in red should show "On" for debug mode.
Comment 2 Pedro Amorim 2023-08-28 13:18:21 UTC
May be a nitpick but perhaps use "Enabled"/"Disabled" instead of "On"/"Off"?
To match what's used on the edit form.
Comment 3 Emily-Rose Francoeur 2023-09-12 14:35:16 UTC
Created attachment 155554 [details] [review]
Bug 34619: Show debug mode column in list of SMTP servers

This patch adds a column to the table of SMTP servers which shows
whether debug mode is on or off. This information was previously only
conveyed through the color of the text in the table row.

To test, apply the patch and go to Administration -> SMTP servers.

- If necessary, add one or more SMTP servers so that there are more than
  one: At least one with debug mode on, at least one with debug mode
  off.
- In the table listing SMTP servers you should see a column for "Debug
  mode," where the rows indicate "On" or "Off."
- Each row which is highlighted in red should show "On" for debug mode.

Signed-off-by: Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com>
Comment 4 Katrin Fischer 2023-09-29 14:49:42 UTC
Created attachment 156407 [details] [review]
Bug 34619: Show debug mode column in list of SMTP servers

This patch adds a column to the table of SMTP servers which shows
whether debug mode is on or off. This information was previously only
conveyed through the color of the text in the table row.

To test, apply the patch and go to Administration -> SMTP servers.

- If necessary, add one or more SMTP servers so that there are more than
  one: At least one with debug mode on, at least one with debug mode
  off.
- In the table listing SMTP servers you should see a column for "Debug
  mode," where the rows indicate "On" or "Off."
- Each row which is highlighted in red should show "On" for debug mode.

Signed-off-by: Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 5 Tomás Cohen Arazi (tcohen) 2023-10-04 13:33:30 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!