Bug 34626

Summary:	Add waiting since date to holdswaiting patron message
Product:	Koha	Reporter:	Lucas Gass (lukeg) <lucas>
Component:	Circulation	Assignee:	Lucas Gass (lukeg) <lucas>
Status:	Needs documenting ---	QA Contact:	Testopia <testopia>
Severity:	enhancement
Priority:	P5 - low	CC:	emily.lamancusa, fridolin.somers, gmcharlt, kebliss, kelly, kyle.m.hall
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Trivial patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	23.11.00
Circulation function:
Attachments:	Bug 34626: Add waitingdate to holdswaiting patron message Bug 34626: Add waitingdate to holdswaiting patron message

Description Lucas Gass (lukeg) 2023-08-25 20:35:50 UTC

On moremember.tt and ciculation.tt there will be a message if the patron has any waiting holds.

This message displays the date the hold was placed on (reserves.reservedate) and the date it will wait until ( reservedate.expirationdate ).

Some libraries would like to add the 'Waiting since' date. ( reservedate.waitingdate )

Comment 1 Lucas Gass (lukeg) 2023-08-25 20:41:21 UTC

Created attachment 154851 [details] [review]
Bug 34626: Add waitingdate to holdswaiting patron message

To test:
1. Apply patch
2. Place 2 or more holds for a patron and trigger them so they are waiting holds.
3. Now go to both moremember.tt and circulation.tt for that patron.
4. Confirm that you now see a 'Waiting here since' message.

Comment 2 ByWater Sandboxes 2023-08-31 14:06:13 UTC

Created attachment 155010 [details] [review]
Bug 34626: Add waitingdate to holdswaiting patron message

To test:
1. Apply patch
2. Place 2 or more holds for a patron and trigger them so they are waiting holds.
3. Now go to both moremember.tt and circulation.tt for that patron.
4. Confirm that you now see a 'Waiting here since' message.

Signed-off-by: Kelly <kelly@bywatersolutions.com>

Comment 3 Emily Lamancusa (emlam) 2023-09-15 21:02:15 UTC

Trivial change, QA tool is happy. Passing QA

Comment 4 Katrin Fischer 2023-09-15 21:18:53 UTC

Hi Emlam, please sign-off and re-attach the patches when passing QA!

Comment 5 Tomás Cohen Arazi (tcohen) 2023-09-18 18:54:56 UTC

Pushed to master for 23.11.

Nice work everyone, thanks!

Comment 6 Fridolin Somers 2023-09-18 21:52:26 UTC

Enhancement not pushed to 23.05.x

Comment 7 Emily Lamancusa (emlam) 2023-09-26 14:39:21 UTC

(In reply to Katrin Fischer from comment #4)
> Hi Emlam, please sign-off and re-attach the patches when passing QA!

Oops, I seem to have missed that I should be doing that. I'll make sure to add my sign-off going forward!