|
Description
Nick Clemens (kidclamp)
2023-08-29 17:26:08 UTC
Created attachment 154913 [details] [review] Bug 34644: Add clarifying text to sysprefs to indicate that MarcFieldsToOrder is a fallback to MarcItemFieldsToOrder Clarify that fields will fall back to MarcFieldsToOrder from MarcItemFieldsToOrder. Created attachment 154914 [details] [review] Bug 34644: Improve readability of sysprefs Created attachment 154916 [details] [review] Bug 34644: replacementprice is support by MarcFieldsToOrder but is not listed Created attachment 154929 [details] [review] Bug 34644: Add clarifying text to sysprefs to indicate that MarcFieldsToOrder is a fallback to MarcItemFieldsToOrder Clarify that fields will fall back to MarcFieldsToOrder from MarcItemFieldsToOrder. Signed-off-by: David Nind <david@davidnind.com> Created attachment 154930 [details] [review] Bug 34644: Improve readability of sysprefs Signed-off-by: David Nind <david@davidnind.com> Created attachment 154931 [details] [review] Bug 34644: replacementprice is support by MarcFieldsToOrder but is not listed Signed-off-by: David Nind <david@davidnind.com> Created attachment 154932 [details] [review] Bug 34644: (follow-up) Additional edits to description Linked system preference in description to cross reference, and and removed the spaces in the bracketed text. Signed-off-by: David Nind <david@davidnind.com> Testing notes: 1. Compared before and after text for the system preference. 2. I added a follow-up - linked system preference in the description for MarcItemFieldsToOrder (the same as we do for other preferences), and removed the spaces in the bracketed text. A nice clarification! Moving to blocked since depends on a NSO. Dependency is unlocked. Blocked again :( Created attachment 160019 [details] [review] Bug 34644: Add clarifying text to sysprefs to indicate that MarcFieldsToOrder is a fallback to MarcItemFieldsToOrder Clarify that fields will fall back to MarcFieldsToOrder from MarcItemFieldsToOrder. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 160020 [details] [review] Bug 34644: Improve readability of sysprefs Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 160021 [details] [review] Bug 34644: replacementprice is support by MarcFieldsToOrder but is not listed Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 160022 [details] [review] Bug 34644: (follow-up) Additional edits to description Linked system preference in description to cross reference, and and removed the spaces in the bracketed text. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> That's a lot of patches for a minor string change in the end. Still.. it is clearer now. Passing QA Pushed for 24.05! Well done everyone, thank you! Pushed to 23.11.x for 23.11.02 Backported to 23.05.x for upcoming 23.05.08 |