Description
Nick Clemens (kidclamp)
2023-08-30 13:26:52 UTC
Created attachment 154957 [details] [review] Bug 34656: Unit test Created attachment 154958 [details] [review] Bug 34656: Do not update real Time Holds Queue when moving from cart to shelf To test: 1 - Enable RealTimeHoldsQueue system preference 2 - Set UpdateItemLocationOnCheckin to _ALL_: CART 3 - Check in an item 4 - Check the background jobs - the RTHQ is updated 5 - perl -e 'use C4::Items; C4::Items::CartToShelf(##);' -- substitute the itemnumber from above 6 - Check the background jobs - no new update to RTHQ 7 - Confirm item was set back to correct permanent_location Created attachment 155011 [details] [review] Bug 34656: Unit test Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Created attachment 155012 [details] [review] Bug 34656: Do not update real Time Holds Queue when moving from cart to shelf To test: 1 - Enable RealTimeHoldsQueue system preference 2 - Set UpdateItemLocationOnCheckin to _ALL_: CART 3 - Check in an item 4 - Check the background jobs - the RTHQ is updated 5 - perl -e 'use C4::Items; C4::Items::CartToShelf(##);' -- substitute the itemnumber from above 6 - Check the background jobs - no new update to RTHQ 7 - Confirm item was set back to correct permanent_location Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Created attachment 155013 [details] [review] Bug 34656: (QA follow-up) perltidy Testing notes: For step 3, you need to check out and then check in the item in order to generate RTHQ updates - an update won't trigger on check-in if the item wasn't checked out in the first place. Also - if the holds queue background jobs generated by CartToShelf can cause issues by clashing with the holds queue builder, wouldn't *anything* that causes a real-time holds queue update potentially cause the same issue? I agree with eliminating unnecessary background jobs for its own sake, but there seems to be a bigger bug lurking underneath. (creating a new bug report for it) Created attachment 155207 [details] [review] Bug 34656: Unit test Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Created attachment 155208 [details] [review] Bug 34656: Do not update real Time Holds Queue when moving from cart to shelf To test: 1 - Enable RealTimeHoldsQueue system preference 2 - Set UpdateItemLocationOnCheckin to _ALL_: CART 3 - Check in an item 4 - Check the background jobs - the RTHQ is updated 5 - perl -e 'use C4::Items; C4::Items::CartToShelf(##);' -- substitute the itemnumber from above 6 - Check the background jobs - no new update to RTHQ 7 - Confirm item was set back to correct permanent_location Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Created attachment 155209 [details] [review] Bug 34656: (QA follow-up) perltidy Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> I don't get enough the functional side to fully validate this, at least I can tell that the test code looks good and add a 2nd signoff so maybe Emily can pass QA. Thanks, Victor! Passing QA Pushed to master for 23.11. Nice work everyone, thanks! Pushed to 23.05.x for 23.05.04 Nice work everyone! Pushed to oldstable for 22.11.x |