| Summary: | Errors in UNIMARC default framework | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Igor A. Sychev <Igor.A.Sychev> |
| Component: | MARC Bibliographic data support | Assignee: | Caroline Cyr La Rose <caroline.cyr-la-rose> |
| Status: | Pushed to oldstable --- | QA Contact: | Victor Grousset/tuxayo <victor> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | caroline.cyr-la-rose, fridolin.somers, jonathan.druart, lucas, victor |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
24.05.00,23.11.06,23.05.12
|
|
| Circulation function: | |||
| Bug Depends on: | 30373 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 34663: Errors in UNIMARC default framework
Bug 34663: Errors in UNIMARC default framework Bug 34663: Errors in UNIMARC default framework |
||
|
Description
Igor A. Sychev
2023-08-30 16:44:29 UTC
All of the instances of bad tab settings for 400 fields in the default UNIMARC framework are subfield 0, 'Bibliographic Record Identifier.' Could it have been the intention to hide this subfield, or should they all be updated to show in tab 4? Need to link records. All of them should be displayed on tab 4. $0 Bibliographic Record Identifier The contents of the 001 field of the item to which the link is being made. Not repeatable. https://cdn.ifla.org/wp-content/uploads/files/assets/uca/unimarc_updates/BIBLIOGRAPHIC/u-b_4-_linking_entry_block_update.pdf Created attachment 162324 [details] [review] Bug 34663: Errors in UNIMARC default framework This patch corrects the default UNIMARC bibliographic framework to place all the 4XX subfields in tab 4. To test: 1. Go to Administration > MARC Bibliographic framework test --> There should be errors indicating subfields from 4XX fields are in tabs 3 and 4 2. Apply patch and reset_all 3. Redo step 1 --> It should now say that all subfields for each tag are in the same tab (or ignored) Created attachment 162397 [details] [review] Bug 34663: Errors in UNIMARC default framework This patch corrects the default UNIMARC bibliographic framework to place all the 4XX subfields in tab 4. To test: 1. Go to Administration > MARC Bibliographic framework test --> There should be errors indicating subfields from 4XX fields are in tabs 3 and 4 2. Apply patch and reset_all 3. Redo step 1 --> It should now say that all subfields for each tag are in the same tab (or ignored) Signed-off-by: David Nind <david@davidnind.com> Fridolin, please confirm or ask someone to confirm this change please. It seems to be from Bug 30373, the previous unimarc_framework_DEFAULT.sql had the subfields 0 on the right tab (4): https://gitlab.com/bgkriegel/Koha/-/blob/3dd12b8ea283de5d29fd89432a8eb412308261eb/installer/data/mysql/en/marcflavour/unimarc/mandatory/unimarc_framework_DEFAULT.sql The initial migration to the new format had the right tabs. But then a follow-up did many changes including these changes of tab: 674ad809f391cddc83338b7ae787b86e6dd490f2 Bug 30373: Fix visibility, authorised values and descriptions Commit description doesn't hit at such a goal, might have been collateral damage of scripting or mechanical editing of the file. So the changes here seems to make sense. Will test asap. Created attachment 163752 [details] [review] Bug 34663: Errors in UNIMARC default framework This patch corrects the default UNIMARC bibliographic framework to place all the 4XX subfields in tab 4. To test: 1. Go to Administration > MARC Bibliographic framework test --> There should be errors indicating subfields from 4XX fields are in tabs 3 and 4 2. Apply patch and reset_all 3. Redo step 1 --> It should now say that all subfields for each tag are in the same tab (or ignored) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Works, makes sense, QA script happy, code looks good, passing QA :) Pushed for 24.05! Well done everyone, thank you! Pushed to 23.11.x for 23.11.06 Thanks a lot from UNIMARC fan-club ^ Backported to 23.05.x for upcoming 23.05.12 |