Summary: | Cypress - Fix random failure in Dialog_spec.ts | ||
---|---|---|---|
Product: | Koha | Reporter: | Pedro Amorim <pedro.amorim> |
Component: | Test Suite | Assignee: | Pedro Amorim <pedro.amorim> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | fridolin.somers, jonathan.druart, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
23.11.00
|
Circulation function: | |
Bug Depends on: | 34319 | ||
Bug Blocks: | |||
Attachments: |
Bug 34690: Fix dialog_spec.ts
bug 34690: Make the test fail consistently Bug 34690: Fix dialog_spec.ts Bug 34690: Make the test fail consistently Bug 34690: Fix dialog_spec.ts |
Description
Pedro Amorim
2023-09-01 12:02:56 UTC
Created attachment 155113 [details] [review] Bug 34690: Fix dialog_spec.ts Run the tests, verify they fail Apply this patch, run tests again, verify they now pass Created attachment 155115 [details] [review] bug 34690: Make the test fail consistently Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 155116 [details] [review] Bug 34690: Fix dialog_spec.ts Run the tests, verify they fail Apply this patch, run tests again, verify they now pass Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 155231 [details] [review] Bug 34690: Make the test fail consistently Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Edit: I amended the commit title Created attachment 155232 [details] [review] Bug 34690: Fix dialog_spec.ts Run the tests, verify they fail Apply this patch, run tests again, verify they now pass Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Tested on the new Cypress 10.x KTD images. Tests fail consistently with the first patch (good catch!) and they get fixed with the follow-up. Thanks! Pushed to master for 23.11. Nice work everyone, thanks! Not backported to 23.05.x |