| Summary: | Remove use of onclick for opac-privacy.pl | ||
|---|---|---|---|
| Product: | Koha | Reporter: | David Cook <dcook> |
| Component: | OPAC | Assignee: | David Cook <dcook> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | fridolin.somers |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.11.00,23.05.04,22.11.11
|
|
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 34709 | ||
| Attachments: |
Bug 34711: Remove use of onclick for opac-privacy.pl
Bug 34711: Remove use of onclick for opac-privacy.pl Bug 34711: Remove use of onclick for opac-privacy.pl |
||
|
Description
David Cook
2023-09-05 02:49:08 UTC
Created attachment 155210 [details] [review] Bug 34711: Remove use of onclick for opac-privacy.pl This change removes the "onclick" attribute for the buttons on opac-privacy.pl. Note: The Javascript is placed in a separate file, which is the preferred way for Javascript to be handled by Content-Security-Policy Test plan: 0. Apply the patch 1. Go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=OPACPrivacy 2. Set syspref to "Allow" 3. Go to http://localhost:8080/cgi-bin/koha/opac-privacy.pl 4. The confirmation modal appears and "OK" and "Cancel" buttons work as expected Created attachment 155214 [details] [review] Bug 34711: Remove use of onclick for opac-privacy.pl This change removes the "onclick" attribute for the buttons on opac-privacy.pl. Note: The Javascript is placed in a separate file, which is the preferred way for Javascript to be handled by Content-Security-Policy Test plan: 0. Apply the patch 1. Go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=OPACPrivacy 2. Set syspref to "Allow" 3. Go to http://localhost:8080/cgi-bin/koha/opac-privacy.pl 4. The confirmation modal appears and "OK" and "Cancel" buttons work as expected Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 155760 [details] [review] Bug 34711: Remove use of onclick for opac-privacy.pl This change removes the "onclick" attribute for the buttons on opac-privacy.pl. Note: The Javascript is placed in a separate file, which is the preferred way for Javascript to be handled by Content-Security-Policy Test plan: 0. Apply the patch 1. Go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=OPACPrivacy 2. Set syspref to "Allow" 3. Go to http://localhost:8080/cgi-bin/koha/opac-privacy.pl 4. The confirmation modal appears and "OK" and "Cancel" buttons work as expected Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.11. Nice work everyone, thanks! Pushed to 23.05.x for 23.05.04 Nice work everyone! Pushed to oldstable for 22.11.x |