Bug 34721

Summary: Change facet description for Limit to available items to accurately reflect what it does
Product: Koha Reporter: Donna <bwsdonna>
Component: Staff interfaceAssignee: Lucas Gass (lukeg) <lucas>
Status: CLOSED FIXED QA Contact: Katrin Fischer <katrin.fischer>
Severity: enhancement    
Priority: P5 - low CC: caroline.cyr-la-rose, fridolin.somers, gmcharlt, lucas, pedro.amorim, tomascohen
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: String patch Documentation contact: Caroline Cyr La Rose
Documentation submission: https://gitlab.com/koha-community/koha-manual/-/merge_requests/773 Text to go in the release notes:
Version(s) released in:
23.11.00
Circulation function:
Attachments: Bug 34721: Change facet availability text in staff interface and OPAC
Bug 34721: Change facet availability text in staff interface and OPAC
Bug 34721: (QA follow-up) update the other labels
k
Bug 34721: Change facet availability text in staff interface and OPAC
Bug 34721: (QA follow-up) update the other labels

Description Donna 2023-09-05 21:26:06 UTC
In the Staff Interface the facet for "Limit to currently available items" is incorrectly named.  There are a number of bugs in regards to "fixing it", but in the meantime it would be immensely helpful to rename that facet to "Limit to records with available items" for clarity.  

This would be under Availability on both search.pl and the Advanced search page.
Comment 1 Lucas Gass (lukeg) 2023-09-05 21:36:44 UTC
Created attachment 155241 [details] [review]
Bug 34721: Change facet availability text in staff interface and OPAC

To test:
1. Apply patch
2. Do a catalog search in the staff interface. Make sure the 'Availability' button reads 'Limit to records with available items'.
3. Do a catalog search in the OPAC. Make sure the 'Availability' button reads 'Limit to records with available items'.
Comment 2 Pedro Amorim 2023-09-07 13:48:51 UTC
Created attachment 155301 [details] [review]
Bug 34721: Change facet availability text in staff interface and OPAC

To test:
1. Apply patch
2. Do a catalog search in the staff interface. Make sure the 'Availability' button reads 'Limit to records with available items'.
3. Do a catalog search in the OPAC. Make sure the 'Availability' button reads 'Limit to records with available items'.

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Comment 3 Pedro Amorim 2023-09-07 13:48:54 UTC
Created attachment 155302 [details] [review]
Bug 34721: (QA follow-up) update the other labels

Showing only available items -> Showing only records with available items
Show all items -> Show all records

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Comment 4 Pedro Amorim 2023-09-07 13:49:29 UTC
Hi Lucas, please check if you agree with my follow-up.
Comment 5 Lucas Gass (lukeg) 2023-09-07 21:07:57 UTC
(In reply to Pedro Amorim from comment #4)
> Hi Lucas, please check if you agree with my follow-up.

Ah, yes! Good catch. Thanks Pedro!
Comment 6 Katrin Fischer 2023-09-08 09:55:35 UTC
Created attachment 155388 [details] [review]
k
Comment 7 Katrin Fischer 2023-09-08 09:55:53 UTC
Created attachment 155389 [details] [review]
Bug 34721: Change facet availability text in staff interface and OPAC

To test:
1. Apply patch
2. Do a catalog search in the staff interface. Make sure the 'Availability' button reads 'Limit to records with available items'.
3. Do a catalog search in the OPAC. Make sure the 'Availability' button reads 'Limit to records with available items'.

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 8 Katrin Fischer 2023-09-08 09:55:55 UTC
Created attachment 155390 [details] [review]
Bug 34721: (QA follow-up) update the other labels

Showing only available items -> Showing only records with available items
Show all items -> Show all records

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 9 Tomás Cohen Arazi (tcohen) 2023-09-12 13:14:48 UTC
(In reply to Katrin Fischer from comment #6)
> Created attachment 155388 [details] [review] [review]
> k

?
Comment 10 Tomás Cohen Arazi (tcohen) 2023-09-12 13:16:47 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 11 Katrin Fischer 2023-09-12 13:17:43 UTC
(In reply to Tomás Cohen Arazi from comment #9)
> (In reply to Katrin Fischer from comment #6)
> > Created attachment 155388 [details] [review] [review] [review]
> > k
> 
> ?

Ctrl + k in nano.. don't ask.
Comment 12 Fridolin Somers 2023-09-14 18:30:01 UTC
Enhancement not pushed to 23.05.x