Summary: | Remove use of onclick for OPAC cart | ||
---|---|---|---|
Product: | Koha | Reporter: | David Cook <dcook> |
Component: | OPAC | Assignee: | David Cook <dcook> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | minor | ||
Priority: | P5 - low | CC: | fridolin.somers |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34726 | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.11.00,23.05.04,22.11.11
|
|
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 34726, 34709 | ||
Attachments: |
Bug 34725: Remove use of onclick for OPAC cart
Bug 34725: Remove use of onclick for OPAC cart Bug 34725: Remove use of onclick for OPAC cart |
Description
David Cook
2023-09-06 06:46:56 UTC
Created attachment 155256 [details] [review] Bug 34725: Remove use of onclick for OPAC cart This patch moves the click handler in the OPAC cart from the inline HTML and out to an existing <script> element. Test plan: 0. Apply the patch 1. Go to http://localhost:8080/cgi-bin/koha/opac-search.pl?idx=&q=test&weight_search=1 2. Add the results to the cart 3. Click on the "Cart" 4. One by one click on the title of each row 5. Notice how the parent window changes to the detail record for that title Created attachment 155297 [details] [review] Bug 34725: Remove use of onclick for OPAC cart This patch moves the click handler in the OPAC cart from the inline HTML and out to an existing <script> element. Test plan: 0. Apply the patch 1. Go to http://localhost:8080/cgi-bin/koha/opac-search.pl?idx=&q=test&weight_search=1 2. Add the results to the cart 3. Click on the "Cart" 4. One by one click on the title of each row 5. Notice how the parent window changes to the detail record for that title Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Created attachment 155757 [details] [review] Bug 34725: Remove use of onclick for OPAC cart This patch moves the click handler in the OPAC cart from the inline HTML and out to an existing <script> element. Test plan: 0. Apply the patch 1. Go to http://localhost:8080/cgi-bin/koha/opac-search.pl?idx=&q=test&weight_search=1 2. Add the results to the cart 3. Click on the "Cart" 4. One by one click on the title of each row 5. Notice how the parent window changes to the detail record for that title Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.11. Nice work everyone, thanks! Pushed to 23.05.x for 23.05.04 Nice work everyone! Pushed to oldstable for 22.11.x |