Summary: | Prevent error when logging into OPAC after conducting a search | ||
---|---|---|---|
Product: | Koha | Reporter: | Aleisha Amohia <aleisha> |
Component: | OPAC | Assignee: | Aleisha Amohia <aleisha> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | Sponsored | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.11.00,23.05.04,22.11.11
|
|
Circulation function: | |||
Attachments: |
Bug 34760: Confirm session ID is set to save OPAC search history to logged in user
Bug 34760: Confirm session ID is set to save OPAC search history to logged in user Bug 34760: Confirm session ID is set to save OPAC search history to logged in user |
Description
Aleisha Amohia
2023-09-11 20:46:16 UTC
Created attachment 155521 [details] [review] Bug 34760: Confirm session ID is set to save OPAC search history to logged in user This patch confirms that a session ID has been set before trying to save search history to a logged in user on the OPAC. This depends on EnableOpacSearchHistory system preference being enabled. Apply the patch and test that you don't see an Error 500 page at any point through this plan: 1. Do an OPAC search, ensure you are not logged in 2. Confirm your search was saved to search history 3. Do another search, then log in 4. Confirm you are brought back to the search results after logging in 5. Confirm all search history from the session is visible Sponsored-by: Toi Ohomai Institute of Technology Created attachment 155550 [details] [review] Bug 34760: Confirm session ID is set to save OPAC search history to logged in user This patch confirms that a session ID has been set before trying to save search history to a logged in user on the OPAC. This depends on EnableOpacSearchHistory system preference being enabled. Apply the patch and test that you don't see an Error 500 page at any point through this plan: 1. Do an OPAC search, ensure you are not logged in 2. Confirm your search was saved to search history 3. Do another search, then log in 4. Confirm you are brought back to the search results after logging in 5. Confirm all search history from the session is visible Sponsored-by: Toi Ohomai Institute of Technology Signed-off-by: Salah Ghedda <salah.ghedda@inLibro.com> I have mostly done regression testing here as I can't test any of the SSO methods. I also verified it that the behaviour with LoadSearchHistoryToTheFirstLoggedUser is still the same. Created attachment 155762 [details] [review] Bug 34760: Confirm session ID is set to save OPAC search history to logged in user This patch confirms that a session ID has been set before trying to save search history to a logged in user on the OPAC. This depends on EnableOpacSearchHistory system preference being enabled. Apply the patch and test that you don't see an Error 500 page at any point through this plan: 1. Do an OPAC search, ensure you are not logged in 2. Confirm your search was saved to search history 3. Do another search, then log in 4. Confirm you are brought back to the search results after logging in 5. Confirm all search history from the session is visible Sponsored-by: Toi Ohomai Institute of Technology Signed-off-by: Salah Ghedda <salah.ghedda@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.11. Nice work everyone, thanks! Pushed to 23.05.x for 23.05.04 Nice work everyone! Pushed to oldstable for 22.11.x |