Bug 34824

Summary: Add colon after "Title" in new acquisition order details
Product: Koha Reporter: Caroline Cyr La Rose <caroline.cyr-la-rose>
Component: TemplatesAssignee: Laura Escamilla <Laura.escamilla>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: emily.lamancusa, fridolin.somers, Laura.escamilla
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00
Circulation function:
Attachments: Bug 34824: Add missing colon to 'Title' under Catalog Details To test: 0. Add budgets, vendors and baskets to acquisitions, if necessary 1. Go to Acquisitions 2. Click 'Search' next to the vendor search box 3. If you don't already have an open basket, cre
Bug 34824: Added missing colon to 'Title'
Bug 34824: Added missing colon to 'Title'
Bug 34824: Added missing colon to 'Title'
Bug 34824: Added missing colon to 'Title'

Description Caroline Cyr La Rose 2023-09-18 18:22:02 UTC
When adding a title to an acquisition basket, the elements in the "Catalog details" section are all followed by a colon, except "Title".

To recreate:
0. Add budgets, vendors and baskets to acquisitions, if necessary
1. Go to Acquisitions
2. Click 'Search' next to the vendor search box
3. If you don't already have an open basket, create one by clicking New > Basket
4. Click 'Add to basket'
5. Click 'From an external source'
6. Search for a title or author (I searched for Shakespeare in the author field on the Library of Congress server)
7. To the right of a record (with a title) Click the arrow next to the MARC button and choose Order
--> Notice that in the 'Catalog details' section, all labels are followed by a colon except 'Title'
Comment 1 Laura Escamilla 2023-10-19 17:26:57 UTC Comment hidden (obsolete)
Comment 2 Laura Escamilla 2023-10-19 17:48:38 UTC
Created attachment 157471 [details] [review]
Bug 34824: Added missing colon to 'Title'

To test:
0. Add budgets, vendors and baskets to acquisitions, if necessary
1. Go to Acquisitions
2. Click 'Search' next to the vendor search box
3. If you don't already have an open basket, create one by clicking New > Basket
4. Click 'Add to basket'
5. Click 'From an external source'
6. Search for a title or author (I searched for Shakespeare in the author field on the Library of Congress server)
7. To the right of a record (with a title) Click the arrow next to the MARC button and choose Order
--> Notice that in the 'Catalog details' section, all labels are followed by a colon except 'Title'
8. Apply the patch and refresh the page. Notice that ’Title’ now has a colon.
9. Sign off and have a great day!
Comment 3 Owen Leonard 2023-10-20 12:33:42 UTC
Created attachment 157509 [details] [review]
Bug 34824: Added missing colon to 'Title'

To test:
0. Add budgets, vendors and baskets to acquisitions, if necessary
1. Go to Acquisitions
2. Click 'Search' next to the vendor search box
3. If you don't already have an open basket, create one by clicking New
   > Basket
4. Click 'Add to basket'
5. Click 'From an external source'
6. Search for a title or author (I searched for Shakespeare in the
   author field on the Library of Congress server)
7. To the right of a record (with a title) Click the arrow next to the
   MARC button and choose Order
   --> Notice that in the 'Catalog details' section, all labels are
       followed by a colon except 'Title'
8. Apply the patch and refresh the page. Notice that ’Title’ now has a
   colon.
9. Sign off and have a great day!

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 4 ByWater Sandboxes 2023-10-20 15:00:43 UTC
Created attachment 157533 [details] [review]
Bug 34824: Added missing colon to 'Title'

To test:
0. Add budgets, vendors and baskets to acquisitions, if necessary
1. Go to Acquisitions
2. Click 'Search' next to the vendor search box
3. If you don't already have an open basket, create one by clicking New
   > Basket
4. Click 'Add to basket'
5. Click 'From an external source'
6. Search for a title or author (I searched for Shakespeare in the
   author field on the Library of Congress server)
7. To the right of a record (with a title) Click the arrow next to the
   MARC button and choose Order
   --> Notice that in the 'Catalog details' section, all labels are
       followed by a colon except 'Title'
8. Apply the patch and refresh the page. Notice that ’Title’ now has a
   colon.
9. Sign off and have a great day!

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Kelly <kelly@bywatersolutions.com>
Comment 5 Emily Lamancusa (emlam) 2023-10-20 20:25:52 UTC
Created attachment 157575 [details] [review]
Bug 34824: Added missing colon to 'Title'

To test:
0. Add budgets, vendors and baskets to acquisitions, if necessary
1. Go to Acquisitions
2. Click 'Search' next to the vendor search box
3. If you don't already have an open basket, create one by clicking New
   > Basket
4. Click 'Add to basket'
5. Click 'From an external source'
6. Search for a title or author (I searched for Shakespeare in the
   author field on the Library of Congress server)
7. To the right of a record (with a title) Click the arrow next to the
   MARC button and choose Order
   --> Notice that in the 'Catalog details' section, all labels are
       followed by a colon except 'Title'
8. Apply the patch and refresh the page. Notice that ’Title’ now has a
   colon.
9. Sign off and have a great day!

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Kelly <kelly@bywatersolutions.com>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Comment 6 Tomás Cohen Arazi (tcohen) 2023-10-20 20:36:54 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 7 Fridolin Somers 2023-10-26 06:31:49 UTC
Would be great to add a trailing space:
<span class="label">Title: </span>

So that text is exactly like in next line:
<label for="entertitle">Title: </label>

This ensure that text to translate will be the same.