Summary: | Highlight logged-in library in patron searches does not work anymore in new staff interface | ||
---|---|---|---|
Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
Component: | Templates | Assignee: | Fridolin Somers <fridolin.somers> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | david, jonathan.druart, oleonard |
Version: | Main | Keywords: | regression |
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.11.00,23.05.04,22.11.11
|
|
Circulation function: | |||
Bug Depends on: | 30952 | ||
Bug Blocks: | |||
Attachments: |
Bug 34835: Highlight logged-in library in patron searches fix for new staff interface
Bug 34835: Highlight logged-in library in patron searches fix for new staff interface Bug 34835: Highlight logged-in library in patron searches fix for new staff interface |
Description
Fridolin Somers
2023-09-19 22:17:47 UTC
Created attachment 155917 [details] [review] Bug 34835: Highlight logged-in library in patron searches fix for new staff interface Since Bug 30952 the feature from Bug 10902 does not work anymore. The class "currentlibrary" is there but no background color in CSS. Bug 30952 removed it : - background-color: #E6FCB7; This patch restores this rule plus '!important' that is used by class 'ac-currentlibrary' Test plan: 1) Perform a patrons search 2) Check you see green background color for patrons with same branch as currently logged in. Created attachment 155918 [details] [review] Bug 34835: Highlight logged-in library in patron searches fix for new staff interface Since Bug 30952 the feature from Bug 10902 does not work anymore. The class "currentlibrary" is there but no background color in CSS. Bug 30952 removed it : - background-color: #E6FCB7; This patch restores this rule plus '!important' that is used by class 'ac-currentlibrary' Test plan: 1) Perform a patrons search 2) Check you see green background color for patrons with same branch as currently logged in. Signed-off-by: David Nind <david@davidnind.com> Testing notes (using KTD): 1. yarn build after applying the patch (I think this is required). 2. Search results in table now highlights the library name if it matches the current selected library. Shouldn't we remove the padding? Hum I thought we fixed that already (years ago?), but I don't find the bug. Created attachment 155922 [details] [review] Bug 34835: Highlight logged-in library in patron searches fix for new staff interface Since Bug 30952 the feature from Bug 10902 does not work anymore. The class "currentlibrary" is there but no background color in CSS. Bug 30952 removed it : - background-color: #E6FCB7; This patch restores this rule plus '!important' that is used by class 'ac-currentlibrary' Test plan: 1) Perform a patrons search 2) Check you see green background color for patrons with same branch as currently logged in. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 23.11. Nice work everyone, thanks! Pushed to 23.05.x for 23.05.04 Nice work everyone! Pushed to oldstable for 22.11.x |