| Summary: | SIP/ILS.t is failing if the DB has been upgraded | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Test Suite | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | fridolin.somers, m.de.rooy |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.11.00,23.05.04,22.11.11
|
|
| Circulation function: | |||
| Bug Depends on: | 34258 | ||
| Bug Blocks: | 34841 | ||
| Attachments: |
Bug 34846: Fix SIP/ILS.t if DB has been upgraded
Bug 34846: Fix SIP/ILS.t if DB has been upgraded Bug 34846: Fix SIP/ILS.t if DB has been upgraded |
||
Created attachment 155947 [details] [review] Bug 34846: Fix SIP/ILS.t if DB has been upgraded t/db_dependent/SIP/ILS.t .. 12/15 # Failed test 'Renewal succeeded' # at t/db_dependent/SIP/ILS.t line 346. # got: '0' # expected: '1' # Looks like you failed 1 test of 2. t/db_dependent/SIP/ILS.t .. 15/15 # Failed test 'renew' # at t/db_dependent/SIP/ILS.t line 348. # Looks like you failed 1 test of 15. Because renewalsallowed is 0 for upgraded DB, when it's 5 for new install. We need to set the value. Test plan: perl /kohadevbox/misc4dev/run_tests.pl --run-db-upgrade-only prove t/db_dependent/SIP/ILS.t Created attachment 155962 [details] [review] Bug 34846: Fix SIP/ILS.t if DB has been upgraded t/db_dependent/SIP/ILS.t .. 12/15 # Failed test 'Renewal succeeded' # at t/db_dependent/SIP/ILS.t line 346. # got: '0' # expected: '1' # Looks like you failed 1 test of 2. t/db_dependent/SIP/ILS.t .. 15/15 # Failed test 'renew' # at t/db_dependent/SIP/ILS.t line 348. # Looks like you failed 1 test of 15. Because renewalsallowed is 0 for upgraded DB, when it's 5 for new install. We need to set the value. Test plan: perl /kohadevbox/misc4dev/run_tests.pl --run-db-upgrade-only prove t/db_dependent/SIP/ILS.t Signed-off-by: David Nind <david@davidnind.com> Created attachment 156040 [details] [review] Bug 34846: Fix SIP/ILS.t if DB has been upgraded t/db_dependent/SIP/ILS.t .. 12/15 # Failed test 'Renewal succeeded' # at t/db_dependent/SIP/ILS.t line 346. # got: '0' # expected: '1' # Looks like you failed 1 test of 2. t/db_dependent/SIP/ILS.t .. 15/15 # Failed test 'renew' # at t/db_dependent/SIP/ILS.t line 348. # Looks like you failed 1 test of 15. Because renewalsallowed is 0 for upgraded DB, when it's 5 for new install. We need to set the value. Test plan: perl /kohadevbox/misc4dev/run_tests.pl --run-db-upgrade-only prove t/db_dependent/SIP/ILS.t Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to master for 23.11. Nice work everyone, thanks! Pushed to 23.05.x for 23.05.04 Nice work everyone! Pushed to oldstable for 22.11.x |
The number of renewals allowed needs to be mocked/set, or the tests are failing. To recreate: root@kohadevbox:koha$ perl /kohadevbox/misc4dev/run_tests.pl --run-db-upgrade-only kohadev-koha@kohadevbox:koha$ prove t/db_dependent/SIP/ILS.t t/db_dependent/SIP/ILS.t .. 14/15 # Failed test 'Renewal succeeded' # at t/db_dependent/SIP/ILS.t line 346. # got: '0' # expected: '1' # Looks like you failed 1 test of 2. # Failed test 'renew' # at t/db_dependent/SIP/ILS.t line 348. # Looks like you failed 1 test of 15. $transaction->{screen_msg} contains "Item has reached maximum renewals". Please fix ASAP.