| Summary: | Search.t is failing if the DB has been upgraded | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Test Suite | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | fridolin.somers, m.de.rooy |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.11.00,23.05.04,22.11.11
|
|
| Circulation function: | |||
| Bug Depends on: | 24274, 24458 | ||
| Bug Blocks: | 34841 | ||
| Attachments: |
Bug 34847: Fix t/db_dependent/Search.t
Bug 34847: Fix t/db_dependent/Search.t |
||
Created attachment 156083 [details] [review] Bug 34847: Fix t/db_dependent/Search.t If 01e still exists then the test will fail with Truncated incorrect DECIMAL value: '01e' at t/db_dependent/Search.t line 945 Test plan: % perl /kohadevbox/misc4dev/run_tests.pl --run-db-upgrade-only % prove t/db_dependent/Search.t Somebody on 24274 didnt want to remove 01e :) Created attachment 156088 [details] [review] Bug 34847: Fix t/db_dependent/Search.t If 01e still exists then the test will fail with Truncated incorrect DECIMAL value: '01e' at t/db_dependent/Search.t line 945 Test plan: % perl /kohadevbox/misc4dev/run_tests.pl --run-db-upgrade-only % prove t/db_dependent/Search.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to master for 23.11. Nice work everyone, thanks! Pushed to 23.05.x for 23.05.04 Nice work everyone! Pushed to oldstable for 22.11.x |
To recreate: root@kohadevbox:koha$ perl /kohadevbox/misc4dev/run_tests.pl --run-db-upgrade-only kohadev-koha@kohadevbox:koha$ prove t/db_dependent/Search.t [SKIP warnings] # Looks like you planned 94 tests but ran 44. t/db_dependent/Search.t .. 1/3 # Failed test 'MARC21 + DOM' # at t/db_dependent/Search.t line 946. main::run_marc21_search_tests(): DBI Exception: DBD::mysql::db do failed: Truncated incorrect DECIMAL value: '01e' at t/db_dependent/Search.t line 945 main::END(): DBI Exception: DBD::mysql::db do failed: Truncated incorrect DECIMAL value: '01e' at t/db_dependent/Search.t line 0 END failed--call queue aborted. # Looks like your test exited with 11 just after 1. Not sure how we can fix this one :-/