Summary: | SIP/Message.t is failing if the DB has been upgraded | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Test Suite | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers, m.de.rooy |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.11.00,23.05.04,22.11.11
|
|
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 34841 | ||
Attachments: |
Bug 34848: Fix SIP/Message.t if DB has been upgraded
Bug 34848: Fix SIP/Message.t if DB has been upgraded Bug 34848: Fix SIP/Message.t if DB has been upgraded Bug 34848: (QA follow-up) Resolve warn on useless constant |
Description
Jonathan Druart
2023-09-20 13:52:42 UTC
Created attachment 155932 [details] [review] Bug 34848: Fix SIP/Message.t if DB has been upgraded There were a lot of failures (in the context of bug 34841) t/db_dependent/SIP/Message.t .. 2/16 # Failed test 'Found AH field as timestamp in response' # at t/db_dependent/SIP/Message.t line 820. # Failed test 'Found AH field as SQL date in response' # at t/db_dependent/SIP/Message.t line 825. # Looks like you failed 2 tests of 8. t/db_dependent/SIP/Message.t .. 3/16 # Failed test 'Desensitize flag was set for patron category not in inhouse_patron_categories' # at t/db_dependent/SIP/Message.t line 1133. # got: 'N' # expected: 'Y' # Failed test 'Desensitize flag was set for empty inhouse_patron_categories' # at t/db_dependent/SIP/Message.t line 1139. # got: 'N' # expected: 'Y' Because renewalsallowed is 0 for upgraded DB, when it's 5 for new install. We need to set the value. This patch also adds some missing transaction Test plan: perl /kohadevbox/misc4dev/run_tests.pl --run-db-upgrade-only prove t/db_dependent/SIP/Message.t Created attachment 155963 [details] [review] Bug 34848: Fix SIP/Message.t if DB has been upgraded There were a lot of failures (in the context of bug 34841) t/db_dependent/SIP/Message.t .. 2/16 # Failed test 'Found AH field as timestamp in response' # at t/db_dependent/SIP/Message.t line 820. # Failed test 'Found AH field as SQL date in response' # at t/db_dependent/SIP/Message.t line 825. # Looks like you failed 2 tests of 8. t/db_dependent/SIP/Message.t .. 3/16 # Failed test 'Desensitize flag was set for patron category not in inhouse_patron_categories' # at t/db_dependent/SIP/Message.t line 1133. # got: 'N' # expected: 'Y' # Failed test 'Desensitize flag was set for empty inhouse_patron_categories' # at t/db_dependent/SIP/Message.t line 1139. # got: 'N' # expected: 'Y' Because renewalsallowed is 0 for upgraded DB, when it's 5 for new install. We need to set the value. This patch also adds some missing transaction Signed-off-by: David Nind <david@davidnind.com> Created attachment 156037 [details] [review] Bug 34848: Fix SIP/Message.t if DB has been upgraded There were a lot of failures (in the context of bug 34841) t/db_dependent/SIP/Message.t .. 2/16 # Failed test 'Found AH field as timestamp in response' # at t/db_dependent/SIP/Message.t line 820. # Failed test 'Found AH field as SQL date in response' # at t/db_dependent/SIP/Message.t line 825. # Looks like you failed 2 tests of 8. t/db_dependent/SIP/Message.t .. 3/16 # Failed test 'Desensitize flag was set for patron category not in inhouse_patron_categories' # at t/db_dependent/SIP/Message.t line 1133. # got: 'N' # expected: 'Y' # Failed test 'Desensitize flag was set for empty inhouse_patron_categories' # at t/db_dependent/SIP/Message.t line 1139. # got: 'N' # expected: 'Y' Because renewalsallowed is 0 for upgraded DB, when it's 5 for new install. We need to set the value. This patch also adds some missing transaction Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 156038 [details] [review] Bug 34848: (QA follow-up) Resolve warn on useless constant Useless use of a constant ("Dies if sip user cannot be found") in void context at t/db_dependent/SIP/Message.t line 582. We should remove the comma.. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to master for 23.11. Nice work everyone, thanks! Pushed to 23.05.x for 23.05.04 Nice work everyone! Pushed to oldstable for 22.11.x |