| Summary: | Move EDI link to new line in invoice column of acquisition details display | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
| Component: | Acquisitions | Assignee: | Martin Renvoize (ashimema) <martin.renvoize> |
| Status: | RESOLVED FIXED | QA Contact: | Kyle M Hall (khall) <kyle> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | fridolin.somers, jeremy.evans, kyle, oleonard, victor |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
24.05.00,23.11.03
|
|
| Circulation function: | |||
| Bug Depends on: | 32984 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 34853: Add clearfix span to Invoice links
Bug 34853: Add clearfix span to Invoice links Bug 34853: Add clearfix span to Invoice links Bug 34853: Switch to 'div' as suggested |
||
|
Description
Martin Renvoize (ashimema)
2023-09-20 15:42:45 UTC
Created attachment 155953 [details] [review] Bug 34853: Add clearfix span to Invoice links This patch adds a clearfix span around the invoicenumber and EDI message display texts which should result in them each having their own line. Created attachment 155954 [details] [review] Bug 34853: Add clearfix span to Invoice links This patch adds a clearfix span around the invoicenumber and EDI message display texts which should result in them each having their own line. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Hi, I know nothing about EDI, does the test plan of Bug 28640 helps? I'm trying to get «1) Find or create an item invoiced via an EDI INVOICE message» from bug 32984's test plan. But when looking at Bug 28640, this doesn't go as expected: > 5/ The 'EDI status' should continue to display 'Not ordered' > 6/ Re-open the basket > 7/ Close the basket via 'Create EDIFACT order' I have my vendor with a (too?) minimally filled EDI account. (orders and invoices enabled). And a minimally filled EAN for all libraries. Maybe this doesn't make any sense this ticket. > 7/ Close the basket via 'Create EDIFACT order' oops, missed the steps that actually block me: > 8/ Navigate back to the now closed basket > 9/ Note the 'EDI status' field now displays 'Pending' and the transfer date. Still 'Not ordered' A test plan or some test data to quickly import would be great. After talking to Owen: why not simply use a div instead of the span? (no class needed) I used a span with clearfix as that's three interface pattern is seen to date for this. This was also meant to be a tiny and quick follow up to the previous bug. Created attachment 161069 [details] [review] Bug 34853: Add clearfix span to Invoice links This patch adds a clearfix span around the invoicenumber and EDI message display texts which should result in them each having their own line. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 161070 [details] [review] Bug 34853: Switch to 'div' as suggested This patch switches us from '<span class="clearfix">' to '<div>' so we're just using a block level elemenet instead of manipulating an inline element to act like a block. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Pushed for 24.05! Well done everyone, thank you! Pushed to 23.11.x for 23.11.03 |