| Summary: | "Sending your cart/list" headings are inconsistent | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
| Component: | Staff interface | Assignee: | Owen Leonard <oleonard> |
| Status: | RESOLVED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | caroline.cyr-la-rose, david, fridolin.somers, gmcharlt |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.11.00
|
|
| Circulation function: | |||
| Attachments: |
Bug 34873: Fix inconsistencies between "Sending your cart/list" headings
Bug 34873: Fix inconsistencies between "Sending your cart/list" headings Screenshot - Send cart and lists pop-up windows Bug 34873: Fix inconsistencies between "Sending your cart/list" headings |
||
|
Description
Katrin Fischer
2023-09-21 21:00:22 UTC
Created attachment 156377 [details] [review] Bug 34873: Fix inconsistencies between "Sending your cart/list" headings This patch modifies the templates for the popup windows which are shown when you send a cart or a list via email in the staff interface. To test, apply the patch and log into the staff interface. - Perform a catalog search which will return results. - Select one or more results and add them to the cart. - Click the cart icon in the header menu to open the Cart popup. - Click "Send". Compare this pop-up window to the version shown when sending a list: - Open the Lists page and view the contents of a list. - Click the "Send list" button in the toolbar. - This popup should look correct and be consistent with the Cart version. Created attachment 156449 [details] [review] Bug 34873: Fix inconsistencies between "Sending your cart/list" headings This patch modifies the templates for the popup windows which are shown when you send a cart or a list via email in the staff interface. To test, apply the patch and log into the staff interface. - Perform a catalog search which will return results. - Select one or more results and add them to the cart. - Click the cart icon in the header menu to open the Cart popup. - Click "Send". Compare this pop-up window to the version shown when sending a list: - Open the Lists page and view the contents of a list. - Click the "Send list" button in the toolbar. - This popup should look correct and be consistent with the Cart version. Signed-off-by: David Nind <david@davidnind.com> Created attachment 156450 [details]
Screenshot - Send cart and lists pop-up windows
I've signed off as they now look much more consistent!
However, I did note that for the cart there is a more space before the heading than with the list (see attached image).
My CSS is not that great, but maybe this is something to do with the div for the container.
Created attachment 156678 [details] [review] Bug 34873: Fix inconsistencies between "Sending your cart/list" headings This patch modifies the templates for the popup windows which are shown when you send a cart or a list via email in the staff interface. To test, apply the patch and log into the staff interface. - Perform a catalog search which will return results. - Select one or more results and add them to the cart. - Click the cart icon in the header menu to open the Cart popup. - Click "Send". Compare this pop-up window to the version shown when sending a list: - Open the Lists page and view the contents of a list. - Click the "Send list" button in the toolbar. - This popup should look correct and be consistent with the Cart version. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.11. Nice work everyone, thanks! Enhancement not pushed to 23.05.x As far as I can see, this doesn't change anything for the manual. Feel free to reopen with more details if I'm wrong. |