Bug 34885

Summary: Improve confusing pref description for OPACHoldsIfAvailableAtPickup
Product: Koha Reporter: Marcel de Rooy <m.de.rooy>
Component: Architecture, internals, and plumbingAssignee: Marcel de Rooy <m.de.rooy>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: fridolin.somers
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.05,22.11.11
Circulation function:
Attachments: Bug 34885: Improve confusing pref description for OPACHoldsIfAvailableAtPickup
Bug 34885: Improve confusing pref description for OPACHoldsIfAvailableAtPickup

Description Marcel de Rooy 2023-09-22 12:14:48 UTC
See 17453/33087.

"> Isnt this confusing? This is not about picking up, this is about placing
> holds.
> 
> So I would prefer to say:
> Do not allow to place holds at libraries where the item is available."

Taking into account:

"But for what it's worth, I'd make sure we still include 'pick-up location' in the description. What's going on here influences the list of pick-up locations and that's something people might search for."
Comment 1 Marcel de Rooy 2023-09-22 13:10:49 UTC
Created attachment 156092 [details] [review]
Bug 34885: Improve confusing pref description for OPACHoldsIfAvailableAtPickup

Changes pref description and sysprefs.sql.
The change is not important enough for a dbrev.

Test plan:
Look at the changed text in Systempreferences.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 2 Marcel de Rooy 2023-09-22 13:11:14 UTC
Trivial: self SO
Comment 3 Katrin Fischer 2023-09-22 13:56:21 UTC
Created attachment 156096 [details] [review]
Bug 34885: Improve confusing pref description for OPACHoldsIfAvailableAtPickup

Changes pref description and sysprefs.sql.
The change is not important enough for a dbrev.

Test plan:
Look at the changed text in Systempreferences.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 4 Tomás Cohen Arazi (tcohen) 2023-09-22 14:04:13 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 5 Fridolin Somers 2023-10-05 18:25:00 UTC
Pushed to 23.05.x for 23.05.05
Comment 6 Jacob O'Mara 2023-10-17 13:37:52 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x