|
Description
Fridolin Somers
2023-09-26 07:52:21 UTC
Created attachment 156253 [details] [review] Bug 34910: Do not allow checkout for anonymous patron Created attachment 156254 [details] [review] Bug 34910: Do not allow checkout for anonymous patron The anonymous patron circulation page should show an alert message and not allow check-out. 1) Configure an existing borrowernumber in system preference AnonymousPatron 2) Go to circulation page of this borrower : /cgi-bin/koha/circ/circulation.pl?borrowernumber=x 3) Check you see alert 'This is the anonymous patron, so circulation is disabled.' Created attachment 156255 [details] [review] Bug 34910: (follow-up) alert in patron details The anonymous patron details page should show an alert message. 1) Configure an existing borrowernumber in system preference 'AnonymousPatron' 2) Go to details page of this borrower : /cgi-bin/koha/members/moremember.pl?borrowernumber=x 3) Check you see alert 'This is the anonymous patron.' BTW we may also change in circulation history, not show the patron details when it is the anonymous. Just write 'Anonymized'. Created attachment 156289 [details] [review] Bug 34910: Do not allow checkout for anonymous patron The anonymous patron circulation page should show an alert message and not allow check-out. 1) Configure an existing borrowernumber in system preference AnonymousPatron 2) Go to circulation page of this borrower : /cgi-bin/koha/circ/circulation.pl?borrowernumber=x 3) Check you see alert 'This is the anonymous patron, so circulation is disabled.' Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Created attachment 156290 [details] [review] Bug 34910: (follow-up) alert in patron details The anonymous patron details page should show an alert message. 1) Configure an existing borrowernumber in system preference 'AnonymousPatron' 2) Go to details page of this borrower : /cgi-bin/koha/members/moremember.pl?borrowernumber=x 3) Check you see alert 'This is the anonymous patron.' Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Hi Kelly. It looks like you've signed off but haven't updated the status... David Created attachment 157059 [details] [review] Bug 34910: Do not allow checkout for anonymous patron The anonymous patron circulation page should show an alert message and not allow check-out. 1) Configure an existing borrowernumber in system preference AnonymousPatron 2) Go to circulation page of this borrower : /cgi-bin/koha/circ/circulation.pl?borrowernumber=x 3) Check you see alert 'This is the anonymous patron, so circulation is disabled.' Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Johanna Miettunen <johanna.miettunen@haaga-helia.fi> Created attachment 157060 [details] [review] Bug 34910: (follow-up) alert in patron details The anonymous patron details page should show an alert message. 1) Configure an existing borrowernumber in system preference 'AnonymousPatron' 2) Go to details page of this borrower : /cgi-bin/koha/members/moremember.pl?borrowernumber=x 3) Check you see alert 'This is the anonymous patron.' Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Johanna Miettunen <johanna.miettunen@haaga-helia.fi> Created attachment 157061 [details] [review] Bug 34910: Do not allow checkout for anonymous patron The anonymous patron circulation page should show an alert message and not allow check-out. 1) Configure an existing borrowernumber in system preference AnonymousPatron 2) Go to circulation page of this borrower : /cgi-bin/koha/circ/circulation.pl?borrowernumber=x 3) Check you see alert 'This is the anonymous patron, so circulation is disabled.' Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Päivi Knuutinen <paivi.knuutinen@joensuu.fi> Created attachment 157062 [details] [review] Bug 34910: (follow-up) alert in patron details The anonymous patron details page should show an alert message. 1) Configure an existing borrowernumber in system preference 'AnonymousPatron' 2) Go to details page of this borrower : /cgi-bin/koha/members/moremember.pl?borrowernumber=x 3) Check you see alert 'This is the anonymous patron.' Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Päivi Knuutinen <paivi.knuutinen@joensuu.fi> Works exactly as described. This works as described, but only solves the issue on template side. We now have an API route for checkouts, should we add something there as well? ILS-DI? A small glitch that we could also fix separately: The messages on details/checkouts show up in different spots, one below and one above the heading. But this is also the case for other existing messages on these pages now. Created attachment 157156 [details] [review] Bug 34910: Do not allow checkout for anonymous patron The anonymous patron circulation page should show an alert message and not allow check-out. 1) Configure an existing borrowernumber in system preference AnonymousPatron 2) Go to circulation page of this borrower : /cgi-bin/koha/circ/circulation.pl?borrowernumber=x 3) Check you see alert 'This is the anonymous patron, so circulation is disabled.' Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Päivi Knuutinen <paivi.knuutinen@joensuu.fi> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 157157 [details] [review] Bug 34910: (follow-up) alert in patron details The anonymous patron details page should show an alert message. 1) Configure an existing borrowernumber in system preference 'AnonymousPatron' 2) Go to details page of this borrower : /cgi-bin/koha/members/moremember.pl?borrowernumber=x 3) Check you see alert 'This is the anonymous patron.' Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Päivi Knuutinen <paivi.knuutinen@joensuu.fi> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 157158 [details] [review] Bug 34910: Do not allow checkout for anonymous patron The anonymous patron circulation page should show an alert message and not allow check-out. 1) Configure an existing borrowernumber in system preference AnonymousPatron 2) Go to circulation page of this borrower : /cgi-bin/koha/circ/circulation.pl?borrowernumber=x 3) Check you see alert 'This is the anonymous patron, so circulation is disabled.' Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Johanna Miettunen <johanna.miettunen@haaga-helia.fi> Signed-off-by: Päivi Knuutinen <paivi.knuutinen@joensuu.fi> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 157159 [details] [review] Bug 34910: (follow-up) alert in patron details The anonymous patron details page should show an alert message. 1) Configure an existing borrowernumber in system preference 'AnonymousPatron' 2) Go to details page of this borrower : /cgi-bin/koha/members/moremember.pl?borrowernumber=x 3) Check you see alert 'This is the anonymous patron.' Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Johanna Miettunen <johanna.miettunen@haaga-helia.fi> Signed-off-by: Päivi Knuutinen <paivi.knuutinen@joensuu.fi> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.11. Nice work everyone, thanks! Pushed to 23.05.x for 23.05.06 Nice work everyone! Pushed to oldstable for 22.11.x |