Summary: | ArticleRequests.t may fail on wrong borrowernumber | ||
---|---|---|---|
Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
Component: | Architecture, internals, and plumbing | Assignee: | Marcel de Rooy <m.de.rooy> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | minor | ||
Priority: | P5 - low | CC: | fridolin.somers |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.11.00,23.05.05,22.11.11
|
|
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 34933 | ||
Attachments: |
Bug 34916: Fix wrong borrowernumber in ArticleRequests.t
Bug 34916: Fix wrong borrowernumber in ArticleRequests.t |
Description
Marcel de Rooy
2023-09-26 13:44:02 UTC
Created attachment 156227 [details] [review] Bug 34916: Fix wrong borrowernumber in ArticleRequests.t Simple fix: Send patron to userenv instead of library only. Test plan: Do not apply patch. Remove borrowernumber 51. Run t/db_dependent/Koha/ArticleRequests.t. (FAIL) Apply patch, rerun test (PASS) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Trivial: self SO This may affect more tests, but I stumbled over this prominent example. Created attachment 156381 [details] [review] Bug 34916: Fix wrong borrowernumber in ArticleRequests.t Simple fix: Send patron to userenv instead of library only. Test plan: Do not apply patch. Remove borrowernumber 51. Run t/db_dependent/Koha/ArticleRequests.t. (FAIL) Apply patch, rerun test (PASS) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Pushed to master for 23.11. Nice work everyone, thanks! Pushed to 23.05.x for 23.05.05 Nice work everyone! Pushed to oldstable for 22.11.x |