Bug 34923

Summary:	OPAC hold page flatpickr does not allow direct input of dates
Product:	Koha	Reporter:	Lucas Gass (lukeg) <lucas>
Component:	OPAC	Assignee:	Lucas Gass (lukeg) <lucas>
Status:	CLOSED FIXED	QA Contact:	Katrin Fischer <katrin.fischer>
Severity:	trivial
Priority:	P5 - low	CC:	david, fridolin.somers
Version:	Main
Hardware:	All
OS:	All
See Also:	https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33821
Change sponsored?:	---	Patch complexity:	Trivial patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	23.11.00,23.05.05,22.11.11
Circulation function:
Bug Depends on:	33821
Bug Blocks:	33703
Attachments:	Bug 34923: Allow direct input of hold dates on opac-reserve.tt Bug 34923: Allow direct input of hold dates on opac-reserve.tt Bug 34923: Allow direct input of hold dates on opac-reserve.tt

Description Lucas Gass (lukeg) 2023-09-26 19:03:15 UTC

Bug 33821 made it so flatpickr inputs can allow for the direct input of dates. This does not work on the holds page for the hold date from date and future date.

We should make the date inputs work the same across the OPAC.

To recreate: 
1. Turn on AllowHoldDateInFuture and OPACAllowHoldDateInFuture
2. Make a hold in OPAC and notice you cannot directly input a date in either the "Hold starts on date:" field or the "Hold not needed after:" field.

Comment 1 Lucas Gass (lukeg) 2023-09-26 19:20:46 UTC

Created attachment 156242 [details] [review]
Bug 34923: Allow direct input of hold dates on opac-reserve.tt

To test:
1. Turn on AllowHoldDateInFuture and OPACAllowHoldDateInFuture
2. Make a hold in OPAC and notice you cannot directly input a date in either the "Hold starts on date:" field or the "Hold not needed after:" field.
3. APPLY PATCH
4. Clear your browser cache and try again. You should be able to directly input dates.

Comment 2 David Nind 2023-09-26 20:16:28 UTC

Created attachment 156244 [details] [review]
Bug 34923: Allow direct input of hold dates on opac-reserve.tt

To test:
1. Turn on AllowHoldDateInFuture and OPACAllowHoldDateInFuture
2. Make a hold in OPAC and notice you cannot directly input a date in either the "Hold starts on date:" field or the "Hold not needed after:" field.
3. APPLY PATCH
4. Clear your browser cache and try again. You should be able to directly input dates.

Signed-off-by: David Nind <david@davidnind.com>

Comment 3 Katrin Fischer 2023-09-29 11:25:43 UTC

Created attachment 156379 [details] [review]
Bug 34923: Allow direct input of hold dates on opac-reserve.tt

To test:
1. Turn on AllowHoldDateInFuture and OPACAllowHoldDateInFuture
2. Make a hold in OPAC and notice you cannot directly input a date in either the "Hold starts on date:" field or the "Hold not needed after:" field.
3. APPLY PATCH
4. Clear your browser cache and try again. You should be able to directly input dates.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Comment 4 Tomás Cohen Arazi (tcohen) 2023-10-04 20:44:12 UTC

Pushed to master for 23.11.

Nice work everyone, thanks!

Comment 5 Fridolin Somers 2023-10-06 00:54:16 UTC

Pushed to 23.05.x for 23.05.05

Comment 6 Matt Blenkinsop 2023-10-17 17:36:19 UTC

Nice work everyone!

Pushed to oldstable for 22.11.x