| Summary: | Remove the use of event attributes from OPAC lists page | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | dcook, fridolin.somers, pedro.amorim, testopia |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.11.00,23.05.05,22.11.11
|
|
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 34709 | ||
| Attachments: |
Bug 34934: Remove the use of event attributes from OPAC lists page
Bug 34934: Remove the use of event attributes from OPAC lists page Bug 34934: Remove the use of event attributes from OPAC lists page |
||
|
Description
Owen Leonard
2023-09-27 15:43:03 UTC
Created attachment 156298 [details] [review] Bug 34934: Remove the use of event attributes from OPAC lists page This patch removes the use of event attributes (onclick, onchange) from the OPAC lists template. These events are defined now along with the other in-page JS. The patch also removes a "delete list" button which was only shown when viewing an empty list and which was redundant. To test, apply the patch and log into the OPAC. - Go to Lists -> New list. - Change the category to "Private" and the "Allow changes" dropdown to "Staff only." - You should see a message, 'The "Staff only" permission has no actual effect while this list is strictly private' - Change the category to "Public." The message should disappear. - View the contents of a list. - Click the "Send list" button at the top of the table of titles. - It should trigger the "Sending your list" popup window. Created attachment 156313 [details] [review] Bug 34934: Remove the use of event attributes from OPAC lists page This patch removes the use of event attributes (onclick, onchange) from the OPAC lists template. These events are defined now along with the other in-page JS. The patch also removes a "delete list" button which was only shown when viewing an empty list and which was redundant. To test, apply the patch and log into the OPAC. - Go to Lists -> New list. - Change the category to "Private" and the "Allow changes" dropdown to "Staff only." - You should see a message, 'The "Staff only" permission has no actual effect while this list is strictly private' - Change the category to "Public." The message should disappear. - View the contents of a list. - Click the "Send list" button at the top of the table of titles. - It should trigger the "Sending your list" popup window. Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Created attachment 156391 [details] [review] Bug 34934: Remove the use of event attributes from OPAC lists page This patch removes the use of event attributes (onclick, onchange) from the OPAC lists template. These events are defined now along with the other in-page JS. The patch also removes a "delete list" button which was only shown when viewing an empty list and which was redundant. To test, apply the patch and log into the OPAC. - Go to Lists -> New list. - Change the category to "Private" and the "Allow changes" dropdown to "Staff only." - You should see a message, 'The "Staff only" permission has no actual effect while this list is strictly private' - Change the category to "Public." The message should disappear. - View the contents of a list. - Click the "Send list" button at the top of the table of titles. - It should trigger the "Sending your list" popup window. Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Pushed to master for 23.11. Nice work everyone, thanks! Pushed to 23.05.x for 23.05.05 Nice work everyone! Pushed to oldstable for 22.11.x |