Summary: | Add collection column to holds ratio report (circ/reserveratios.pl) | ||
---|---|---|---|
Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
Component: | Circulation | Assignee: | Lucas Gass (lukeg) <lucas> |
Status: | RESOLVED FIXED | QA Contact: | Kyle M Hall (khall) <kyle> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, kkrueger, kyle.m.hall, kyle, lucy.vaux-harvey, pedro.amorim, wizzyrea |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Lucy Vaux-Harvey | Documentation submission: | https://gitlab.com/koha-community/koha-manual/-/merge_requests/824 |
Text to go in the release notes: | Version(s) released in: |
23.11.00,23.05.06
|
|
Circulation function: | |||
Attachments: |
Bug 34938: Add collection column to hold ratio report
HoldsRatio_Screenshot Bug 34938: Add collection column to hold ratio report Bug 34938: Add collection column to hold ratio report Bug 34938: (QA follow-up) Tidy code |
Description
Lucas Gass (lukeg)
2023-09-27 18:33:07 UTC
Created attachment 156305 [details] [review] Bug 34938: Add collection column to hold ratio report To test: 1. Create enough holds on items so that they will appear on the holds ratio report. 2. Visit circ/reserveratios.pl by going to Circulation > Holds ratios 3. No collection column. 4. Apply patch and restart services 5. Look again at circ/reserveratios.pl, now you should see a collection column. 6. Ensure that the data in the column looks correct. 7. Go to Administration > Table settings to ensure you can hide that column, and other columns in the table. If testing on KTD you'll likely need to make sure you turn strict_sql_modes off in the koha-conf because it doesn't like GROUP BY. Created attachment 156308 [details]
HoldsRatio_Screenshot
In testing, when I go to Circulation > Holds ratios, I get the errors in the attached screenshot. If this is user error on my part, please let me know how I can adjust. Hi, NOt sure you did anything strictly wrong here - Lucas points out that the testing docker (which the sandboxes use) needs to have a very specific setting disabled, and I'm not sure - but will check! - that the sandboxes allow turning that setting off, which would make it challenging to test this bug there. We'll see if there is a way we can allow this kind of bug to be tested in the sandboxes. Cheers, Liz (In reply to Kristi from comment #4) > In testing, when I go to Circulation > Holds ratios, I get the errors in the > attached screenshot. > If this is user error on my part, please let me know how I can adjust. (In reply to Kristi from comment #4) > In testing, when I go to Circulation > Holds ratios, I get the errors in the > attached screenshot. > If this is user error on my part, please let me know how I can adjust. Kristi, this is the thing I mention here: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34938#c2 KTD and the sandboxes are set by default with SQL strict mode enabled. Since the code in reserveratios.pl contains several GROUP BY's it fails with strict mode on. Created attachment 156462 [details] [review] Bug 34938: Add collection column to hold ratio report To test: 1. Create enough holds on items so that they will appear on the holds ratio report. 2. Visit circ/reserveratios.pl by going to Circulation > Holds ratios 3. No collection column. 4. Apply patch and restart services 5. Look again at circ/reserveratios.pl, now you should see a collection column. 6. Ensure that the data in the column looks correct. 7. Go to Administration > Table settings to ensure you can hide that column, and other columns in the table. Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Created attachment 158347 [details] [review] Bug 34938: Add collection column to hold ratio report To test: 1. Create enough holds on items so that they will appear on the holds ratio report. 2. Visit circ/reserveratios.pl by going to Circulation > Holds ratios 3. No collection column. 4. Apply patch and restart services 5. Look again at circ/reserveratios.pl, now you should see a collection column. 6. Ensure that the data in the column looks correct. 7. Go to Administration > Table settings to ensure you can hide that column, and other columns in the table. Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 158348 [details] [review] Bug 34938: (QA follow-up) Tidy code Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master for 23.11. Nice work everyone, thanks! Small enhancement, I choose to backport Pushed to 23.05.x for 23.05.06 New screenshot added (In reply to Lucy Vaux-Harvey from comment #12) > New screenshot added Lucy, see comment #2: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34938#c2 (In reply to Lucas Gass from comment #13) > (In reply to Lucy Vaux-Harvey from comment #12) > > New screenshot added > > Lucy, see comment #2: > > https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34938#c2 Thanks Lucas, all worked fine for producing a new screenshot for the manual - https://koha-community.org/manual/latest/en/html/circulation.html#hold-ratios |