Bug 34940

Summary: Highlight logged-in library in facets
Product: Koha Reporter: Fridolin Somers <fridolin.somers>
Component: TemplatesAssignee: Fridolin Somers <fridolin.somers>
Status: RESOLVED FIXED QA Contact: Martin Renvoize <martin.renvoize>
Severity: enhancement    
Priority: P5 - low CC: caroline.cyr-la-rose, martin.renvoize, tomascohen
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31742
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31206
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Caroline Cyr La Rose Documentation submission: https://gitlab.com/koha-community/koha-manual/-/merge_requests/773
Text to go in the release notes:
Like in patron searches, records search now uses class 'currentlibrary' to highlight logged-in library in facets.
Version(s) released in:
23.11.00
Bug Depends on: 10902    
Bug Blocks:    
Attachments: Bug 34940: Highlight logged-in library in facets
Bug 34940: Highlight logged-in library in facets
Bug 34940: Highlight logged-in library in facets
Bug 34940: Highlight logged-in library in facets

Description Fridolin Somers 2023-09-27 21:25:29 UTC
Like in patron searches Bug 10902, use class 'currentlibrary' to highlight logged-in library in facets
Comment 1 Fridolin Somers 2023-09-27 21:31:39 UTC
Created attachment 156310 [details] [review]
Bug 34940: Highlight logged-in library in facets

Like in patron searches Bug 10902, use class 'currentlibrary' to highlight logged-in library in facets

Test plan :
1) Set system preference 'DisplayLibraryFacets' to 'both home and holding libraries'
2) Perform a seach that will find items of your logged-in library.
   In KTD, search for 'branch:CPL'
3) Check the facet (home and holding libraries) of your logged-in library is highlighted
Comment 2 David Nind 2023-09-30 05:00:19 UTC
Created attachment 156430 [details] [review]
Bug 34940: Highlight logged-in library in facets

Like in patron searches Bug 10902, use class 'currentlibrary' to highlight logged-in library in facets

Test plan :
1) Set system preference 'DisplayLibraryFacets' to 'both home and holding libraries'
2) Perform a seach that will find items of your logged-in library.
   In KTD, search for 'branch:CPL'
3) Check the facet (home and holding libraries) of your logged-in library is highlighted

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Martin Renvoize 2023-10-17 12:39:08 UTC
Created attachment 157238 [details] [review]
Bug 34940: Highlight logged-in library in facets

Like in patron searches Bug 10902, use class 'currentlibrary' to highlight logged-in library in facets

Test plan :
1) Set system preference 'DisplayLibraryFacets' to 'both home and holding libraries'
2) Perform a seach that will find items of your logged-in library.
   In KTD, search for 'branch:CPL'
3) Check the facet (home and holding libraries) of your logged-in library is highlighted

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize 2023-10-17 12:39:36 UTC
Nice little enhancement.

Works as desired and causes no regressions.. QA scripts happy.

Passing QA
Comment 5 Tomás Cohen Arazi 2023-10-25 13:19:17 UTC
Please rebase ASAP. Thanks!
Comment 6 Martin Renvoize 2023-10-25 14:07:04 UTC
Created attachment 157803 [details] [review]
Bug 34940: Highlight logged-in library in facets

Like in patron searches Bug 10902, use class 'currentlibrary' to highlight logged-in library in facets

Test plan :
1) Set system preference 'DisplayLibraryFacets' to 'both home and holding libraries'
2) Perform a seach that will find items of your logged-in library.
   In KTD, search for 'branch:CPL'
3) Check the facet (home and holding libraries) of your logged-in library is highlighted

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 7 Martin Renvoize 2023-10-25 14:07:34 UTC
Rebased
Comment 8 Tomás Cohen Arazi 2023-10-25 14:11:35 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 9 Fridolin Somers 2023-10-26 08:29:01 UTC
Enhancement not pushed to 23.05.x
Comment 10 Martin Renvoize 2023-10-27 14:56:30 UTC
I reckon this one could be the cause of one of our selenium failures.. investigating now.
Comment 11 Martin Renvoize 2023-10-27 14:58:44 UTC
Ignore that.. it's not this one.
Comment 12 Caroline Cyr La Rose 2023-12-14 20:04:42 UTC
Already in the manual