Summary: | Remove the use of event attributes from self checkout and check-in | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | minor | ||
Priority: | P5 - low | CC: | david, fridolin.somers, testopia, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.11.00,23.05.05,22.11.12
|
|
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 34709 | ||
Attachments: |
Bug 34946: Remove the use of event attributes from self checkout and check-in
Bug 34946: Remove the use of event attributes from self checkout and check-in Bug 34946: Remove the use of event attributes from self checkout and check-in |
Description
Owen Leonard
2023-09-28 12:47:41 UTC
Created attachment 156329 [details] [review] Bug 34946: Remove the use of event attributes from self checkout and check-in This patch removes the use of event attributes from the self checkout and self check-in templates. These events are defined now along with the other in-page JS. To test you must have SelfCheckInModule and WebBasedSelfCheck preferences enabled. - Navigate to the self checkout interface (/cgi-bin/koha/sco/sco-main.pl). - When the page loads, cursor focus should be automatically placed in the barcode field. - Test the "munge history" feature from Bug 10016: [1] Start a web-based self-check session. [2] Enter a patron barcode. [3] Allow the self-check session to time out. [4] Use the back button. You should get the patron barcode entry form; you should not be prompted to resubmit form input. [5] Enter a patron barcode, perform some transactions, then use the finish button. [6] Next, use the back button. You should get the patron barcode entry form. - Test the updated checkout_confirm function by submitting the "magic" barcode for checkout: __KOHA_NEW_CIRC__. The user's session should be ended. - Navigate to the self check-in interface (/cgi-bin/koha/sco/sci-main.pl). - Test the cursor focus and "munge history" feature on this page too. > To test you must have SelfCheckInModule and WebBasedSelfCheck preferences enabled. Is that all to do access the self check-in interface? I get 404 on /cgi-bin/koha/sco/sci-main.pl on both opac and staff > [1] Start a web-based self-check session. self-check-in right? I just discovered the existence of the self-check-in so I can easily confuse the two. I didn't have any issue accessing - using KTD (in KTD need to enable SelfCheckInModule, WebBasedSelfCheck already enabled, only available on the OPAC side - http://127.0.0.1:8080/cgi-bin/koha/sco/sco-main.pl) (In reply to Victor Grousset/tuxayo from comment #2) > I get 404 on /cgi-bin/koha/sco/sci-main.pl on both opac and staff It's sci/sci-main.pl not sco/sci-main.pl T_T > To test you must have SelfCheckInModule and WebBasedSelfCheck
preferences enabled.
And also SelfCheckoutByLogin = cardnumber
Test plan updated.
Created attachment 157574 [details] [review] Bug 34946: Remove the use of event attributes from self checkout and check-in This patch removes the use of event attributes from the self checkout and self check-in templates. These events are defined now along with the other in-page JS. To test you must have SelfCheckInModule and WebBasedSelfCheck preferences enabled. And SelfCheckoutByLogin = cardnumber. - Navigate to the self checkout interface (/cgi-bin/koha/sco/sco-main.pl). - When the page loads, cursor focus should be automatically placed in the barcode field. - Test the "munge history" feature from Bug 10016: [1] Start a web-based self-check session. [2] Enter a patron barcode. [3] Allow the self-check session to time out. [4] Use the back button. You should get the patron barcode entry form; you should not be prompted to resubmit form input. [5] Enter a patron barcode, perform some transactions, then use the finish button. [6] Next, use the back button. You should get the patron barcode entry form. - Test the updated checkout_confirm function by submitting the "magic" barcode for checkout: __KOHA_NEW_CIRC__. The user's session should be ended. - Navigate to the self check-in interface (/cgi-bin/koha/sco/sci-main.pl). - Test the cursor focus and "munge history" feature on this page too. Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> It works! Created attachment 157576 [details] [review] Bug 34946: Remove the use of event attributes from self checkout and check-in This patch removes the use of event attributes from the self checkout and self check-in templates. These events are defined now along with the other in-page JS. To test you must have SelfCheckInModule and WebBasedSelfCheck preferences enabled. And SelfCheckoutByLogin = cardnumber. - Navigate to the self checkout interface (/cgi-bin/koha/sco/sco-main.pl). - When the page loads, cursor focus should be automatically placed in the barcode field. - Test the "munge history" feature from Bug 10016: [1] Start a web-based self-check session. [2] Enter a patron barcode. [3] Allow the self-check session to time out. [4] Use the back button. You should get the patron barcode entry form; you should not be prompted to resubmit form input. [5] Enter a patron barcode, perform some transactions, then use the finish button. [6] Next, use the back button. You should get the patron barcode entry form. - Test the updated checkout_confirm function by submitting the "magic" barcode for checkout: __KOHA_NEW_CIRC__. The user's session should be ended. - Navigate to the self check-in interface (/cgi-bin/koha/sco/sci-main.pl). - Test the cursor focus and "munge history" feature on this page too. Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.11. Nice work everyone, thanks! Pushed to 23.05.x for 23.05.05 Nice work everyone! Pushed to oldstable for 22.11.x |