Bug 34961

Summary:	RSS feed link in OPAC is missing sort parameter
Product:	Koha	Reporter:	Jason Robb <jrobb>
Component:	OPAC	Assignee:	Owen Leonard <oleonard>
Status:	CLOSED FIXED	QA Contact:	Katrin Fischer <katrin.fischer>
Severity:	trivial
Priority:	P5 - low	CC:	david, fridolin.somers
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Trivial patch
Documentation contact:		Documentation submission:
Text to go in the release notes:	This fixes two RSS links in the OPAC search results template so that they include the correct parameters, including the descending sort by acquisition date.	Version(s) released in:	23.11.00,23.05.05,22.11.11
Circulation function:
Attachments:	Bug 34961: Add sort parameter to OPAC search results RSS feed link Bug 34961: Add sort parameter to OPAC search results RSS feed link Bug 34961: Add sort parameter to OPAC search results RSS feed link

Description Jason Robb 2023-09-29 15:09:41 UTC

In the past running a search in the OPAC with sorting included the sort in the RSS link so patrons could use feeds to track when new items are added.

The RSS link no longer appears to retain the sort.

For example, this search:

/cgi-bin/koha/opac-search.pl?idx=kw&q=street&sort_by=acqdate_dsc

Results in this RSS link:

/cgi-bin/koha/opac-search.pl?idx=kw&q=street&format=rss

Comment 1 Owen Leonard 2023-10-02 15:03:34 UTC

Created attachment 156455 [details] [review]
Bug 34961: Add sort parameter to OPAC search results RSS feed link

This patch corrects two RSS links in the OPAC search results template so
that they include the correct parameters, including the descending sort
by acquisition date.

To test, apply the patch and go to the OPAC.

- Perform a catalog search which will return search results.
- Next to the page heading "Your search returned X results" is an RSS
  link. Check the link to confirm that it has all the expected
  parameters:

  opac-search.pl?idx=kw&q=nude&count=50&sort_by=acqdate_dsc&format=rss

- Perform a search which will return no results and check the RSS link
  on that page. It should be the same.

Comment 2 David Nind 2023-10-02 23:49:23 UTC

Created attachment 156466 [details] [review]
Bug 34961: Add sort parameter to OPAC search results RSS feed link

This patch corrects two RSS links in the OPAC search results template so
that they include the correct parameters, including the descending sort
by acquisition date.

To test, apply the patch and go to the OPAC.

- Perform a catalog search which will return search results.
- Next to the page heading "Your search returned X results" is an RSS
  link. Check the link to confirm that it has all the expected
  parameters:

  opac-search.pl?idx=kw&q=nude&count=50&sort_by=acqdate_dsc&format=rss

- Perform a search which will return no results and check the RSS link
  on that page. It should be the same.

Signed-off-by: David Nind <david@davidnind.com>

Comment 3 Katrin Fischer 2023-10-03 10:20:44 UTC

Created attachment 156493 [details] [review]
Bug 34961: Add sort parameter to OPAC search results RSS feed link

This patch corrects two RSS links in the OPAC search results template so
that they include the correct parameters, including the descending sort
by acquisition date.

To test, apply the patch and go to the OPAC.

- Perform a catalog search which will return search results.
- Next to the page heading "Your search returned X results" is an RSS
  link. Check the link to confirm that it has all the expected
  parameters:

  opac-search.pl?idx=kw&q=nude&count=50&sort_by=acqdate_dsc&format=rss

- Perform a search which will return no results and check the RSS link
  on that page. It should be the same.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Comment 4 Tomás Cohen Arazi (tcohen) 2023-10-04 15:09:45 UTC

Pushed to master for 23.11.

Nice work everyone, thanks!

Comment 5 Fridolin Somers 2023-10-06 00:34:25 UTC

Pushed to 23.05.x for 23.05.05

Comment 6 Matt Blenkinsop 2023-10-17 17:24:51 UTC

Nice work everyone!

Pushed to oldstable for 22.11.x