Bug 34966

Summary:	Terminology: Add item form - "Add & duplicate" should be "Add and duplicate"
Product:	Koha	Reporter:	David Nind <david>
Component:	Cataloging	Assignee:	David Nind <david>
Status:	CLOSED FIXED	QA Contact:	Katrin Fischer <katrin.fischer>
Severity:	trivial
Priority:	P5 - low	CC:	fridolin.somers, katariina.hanhisalo, m.de.rooy
Version:	Main	Keywords:	Academy
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	---
Documentation contact:		Documentation submission:
Text to go in the release notes:	This updates the add item form in the staff interface to change the 'Add & duplicate' button to 'Add and duplicate'. (As per the terminology guidelines https://wiki.koha-community.org/wiki/Terminology)	Version(s) released in:	23.11.00,23.05.06,22.11.12
Circulation function:
Attachments:	Bug 34966: Terminology - fix add item form (& to and) Bug 34966: Terminology - fix add item form (& to and) Bug 34966: Terminology - fix add item form (& to and) Bug 34966: Terminology - fix add item form (& to and)

Description David Nind 2023-09-30 06:15:06 UTC

In our terminology guide, & should only be used when it is part of a proper noun or a common abbreviation: https://wiki.koha-community.org/wiki/Terminology

The add item form in the staff interface incorrectly use "Add & duplicate" (New > New item).

To replicate:
1. In the staff interface, search for and select a record.
2. Select New > New item.
3. Note that "Add & duplicate" is one of the action buttons at the bottom of the add item form.

Comment 1 David Nind 2023-09-30 06:37:53 UTC

Created attachment 156435 [details] [review]
Bug 34966: Terminology - fix add item form (& to and)

This patch updates the add item form in the staff interface to
change the 'Add & duplicate' button to 'Add and duplicate'.

In our terminology guide, & should only be used when
it is part of a proper noun or a common abbreviation:
https://wiki.koha-community.org/wiki/Terminology

Test plan:
1. In the staff interface, search for and select a record.
2. Select New > New item.
3. Note that "Add & duplicate" is one of the action buttons at the
bottom of the add item form.
4. Apply the patch.
5. Refresh the page.
6. Note that the action button is now labelled 'Add and duplicate'.
7. Sign off! 8-)

Signed-off-by: David Nind <david@davidnind.com>

Comment 2 ByWater Sandboxes 2023-10-13 10:51:18 UTC

Created attachment 157063 [details] [review]
Bug 34966: Terminology - fix add item form (& to and)

This patch updates the add item form in the staff interface to
change the 'Add & duplicate' button to 'Add and duplicate'.

In our terminology guide, & should only be used when
it is part of a proper noun or a common abbreviation:
https://wiki.koha-community.org/wiki/Terminology

Test plan:
1. In the staff interface, search for and select a record.
2. Select New > New item.
3. Note that "Add & duplicate" is one of the action buttons at the
bottom of the add item form.
4. Apply the patch.
5. Refresh the page.
6. Note that the action button is now labelled 'Add and duplicate'.
7. Sign off! 8-)

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katariina Hanhisalo <katariina.hanhisalo@xamk.fi>

Comment 3 Biblibre Sandboxes 2023-10-13 11:30:19 UTC

Created attachment 157066 [details] [review]
Bug 34966: Terminology - fix add item form (& to and)

This patch updates the add item form in the staff interface to
change the 'Add & duplicate' button to 'Add and duplicate'.

In our terminology guide, & should only be used when
it is part of a proper noun or a common abbreviation:
https://wiki.koha-community.org/wiki/Terminology

Test plan:
1. In the staff interface, search for and select a record.
2. Select New > New item.
3. Note that "Add & duplicate" is one of the action buttons at the
bottom of the add item form.
4. Apply the patch.
5. Refresh the page.
6. Note that the action button is now labelled 'Add and duplicate'.
7. Sign off! 8-)

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katariina Hanhisalo <katariina.hanhisalo@xamk.fi>
Signed-off-by: Reetta Pihlaja <reetta.pihlaja@siilinjarvi.fi>

Comment 4 David Nind 2023-10-13 19:34:53 UTC

Thanks Katariina and Reetta for signing off!

Comment 5 Katrin Fischer 2023-10-14 15:30:51 UTC

Created attachment 157152 [details] [review]
Bug 34966: Terminology - fix add item form (& to and)

This patch updates the add item form in the staff interface to
change the 'Add & duplicate' button to 'Add and duplicate'.

In our terminology guide, & should only be used when
it is part of a proper noun or a common abbreviation:
https://wiki.koha-community.org/wiki/Terminology

Test plan:
1. In the staff interface, search for and select a record.
2. Select New > New item.
3. Note that "Add & duplicate" is one of the action buttons at the
bottom of the add item form.
4. Apply the patch.
5. Refresh the page.
6. Note that the action button is now labelled 'Add and duplicate'.
7. Sign off! 8-)

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katariina Hanhisalo <katariina.hanhisalo@xamk.fi>
Signed-off-by: Reetta Pihlaja <reetta.pihlaja@siilinjarvi.fi>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Comment 6 Katrin Fischer 2023-10-14 15:31:17 UTC

(In reply to David Nind from comment #4)
> Thanks Katariina and Reetta for signing off!

Thanks from me too :) Keep going!

Comment 7 Tomás Cohen Arazi (tcohen) 2023-10-17 17:48:15 UTC

Pushed to master for 23.11.

Nice work everyone, thanks!

Comment 8 Fridolin Somers 2023-11-08 07:08:56 UTC

Pushed to 23.05.x for 23.05.06

Comment 9 Matt Blenkinsop 2023-11-13 15:23:22 UTC

Nice work everyone!

Pushed to oldstable for 22.11.x