| Summary: | Remove the use of event attributes from title-actions-menu.inc in OPAC | ||
|---|---|---|---|
| Product: | Koha | Reporter: | David Cook <dcook> |
| Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | barbara.johnson, fridolin.somers |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.11.00,23.05.05,22.11.12
|
|
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 34709 | ||
| Attachments: |
Bug 34980: Remove the use of event attributes from title-actions-menu.inc in OPAC
Bug 34980: Remove the use of event attributes from title-actions-menu.inc in OPAC Bug 34980: Remove the use of event attributes from title-actions-menu.inc in OPAC |
||
|
Description
David Cook
2023-10-03 23:27:32 UTC
Created attachment 157137 [details] [review] Bug 34980: Remove the use of event attributes from title-actions-menu.inc in OPAC This patch updates the include file used to show actions with each search result, removing two instances of "onclick" in favor of an event handler class which was already in use elsewhere. To test, apply the patch and log in to the OPAC. - Perform a catalog search which will return results. - Test the "Save to lists" link under any search result. The "Save to lists" pop-up window should appear. - View the contents of a list which contains some titles. - Test the "Save to another list" control. The same pop-up window should be triggered. - Tag at least one title in the catalog and view the "Tag cloud" page. - Perform the same test with the "Save to lists" button in the table of our tags. Created attachment 157198 [details] [review] Bug 34980: Remove the use of event attributes from title-actions-menu.inc in OPAC This patch updates the include file used to show actions with each search result, removing two instances of "onclick" in favor of an event handler class which was already in use elsewhere. To test, apply the patch and log in to the OPAC. - Perform a catalog search which will return results. - Test the "Save to lists" link under any search result. The "Save to lists" pop-up window should appear. - View the contents of a list which contains some titles. - Test the "Save to another list" control. The same pop-up window should be triggered. - Tag at least one title in the catalog and view the "Tag cloud" page. - Perform the same test with the "Save to lists" button in the table of our tags. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Created attachment 157214 [details] [review] Bug 34980: Remove the use of event attributes from title-actions-menu.inc in OPAC This patch updates the include file used to show actions with each search result, removing two instances of "onclick" in favor of an event handler class which was already in use elsewhere. To test, apply the patch and log in to the OPAC. - Perform a catalog search which will return results. - Test the "Save to lists" link under any search result. The "Save to lists" pop-up window should appear. - View the contents of a list which contains some titles. - Test the "Save to another list" control. The same pop-up window should be triggered. - Tag at least one title in the catalog and view the "Tag cloud" page. - Perform the same test with the "Save to lists" button in the table of our tags. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.11. Nice work everyone, thanks! Pushed to 23.05.x for 23.05.05 Nice work everyone! Pushed to oldstable for 22.11.x |