Bug 34993

I can confirm that when I set ApplyFrameworkDefaults to apply defaults in all situations, I do not get default values applied either when duplicating an existing record in that framework or when creating a new record in that framework via z39.50.

(In reply to Andrew Fuerste-Henry from comment #1)
> I can confirm that when I set ApplyFrameworkDefaults to apply defaults in
> all situations, I do not get default values applied either when duplicating
> an existing record in that framework or when creating a new record in that
> framework via z39.50.

This was on 22.11.09.000.

Confirmed in master as well.

A git bisect indicates this is likely a side effect of bug 32484 - Enable framework plugins when UseACQFrameworkForBiblioRecords is set. I don't have time to drill down further into debugging this at the moment, but if someone else does, hopefully this will be helpful.

I've increased the importance to major - mainly as it is a regression, as well as the discussion at the koha-US conference and koha-US cataloguing SIG.

*** Bug 33688 has been marked as a duplicate of this bug. ***

*** Bug 34499 has been marked as a duplicate of this bug. ***

*** Bug 34606 has been marked as a duplicate of this bug. ***

Created attachment 158277 [details] [review]
Bug 34993: Pass context parameters to generate_subfield_form

Pass necessary parameters from the UI to ensure that the basic
MARC editor can correctly identify when a framework is changed,
a bib is being duplicated, or a bib is being imported with Z39.50 -
for purposes of filling in default values according to the settings
of ApplyFrameworkDefaults.

To test:
1. Set the system preference ApplyFrameworkDefaults - Select All
2. Create or edit a MARC bibliographic framework with a default value in
   one of the fields (such as 500$a)
3. Go to the Cataloguing module and create a new record using the
   framework from step 2
   --> Confirm that the default value is filled in
4. Search for an existing bib record
5. Click Edit > Edit record to open the basic editor
6. If the field from step 2 already has data, clear it
7. Switch the framework to the framework from step 2
   --> Confirm that the default value is filled in
8. Clear the field again, and save the edit
9. Click Edit > Edit as new (duplicate)
   --> Confirm that the default value is filled in
10. Go to the cataloguing module and do a Z39.50 search
11. Find a record that does not have a value for the subfield from step 2
12. Import the record using the framework from step 2
    --> Confirm that the default value is filled in

Created attachment 158287 [details] [review]
Bug 34993: Pass context parameters to generate_subfield_form

Pass necessary parameters from the UI to ensure that the basic
MARC editor can correctly identify when a framework is changed,
a bib is being duplicated, or a bib is being imported with Z39.50 -
for purposes of filling in default values according to the settings
of ApplyFrameworkDefaults.

To test:
1. Set the system preference ApplyFrameworkDefaults - Select All
2. Create or edit a MARC bibliographic framework with a default value in
   one of the fields (such as 500$a)
3. Go to the Cataloguing module and create a new record using the
   framework from step 2
   --> Confirm that the default value is filled in
4. Search for an existing bib record
5. Click Edit > Edit record to open the basic editor
6. If the field from step 2 already has data, clear it
7. Switch the framework to the framework from step 2
   --> Confirm that the default value is filled in
8. Clear the field again, and save the edit
9. Click Edit > Edit as new (duplicate)
   --> Confirm that the default value is filled in
10. Go to the cataloguing module and do a Z39.50 search
11. Find a record that does not have a value for the subfield from step 2
12. Import the record using the framework from step 2
    --> Confirm that the default value is filled in

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Please remember to run QA tests and perltidy :)

Created attachment 158460 [details] [review]
Bug 34993: Pass context parameters to generate_subfield_form

Pass necessary parameters from the UI to ensure that the basic
MARC editor can correctly identify when a framework is changed,
a bib is being duplicated, or a bib is being imported with Z39.50 -
for purposes of filling in default values according to the settings
of ApplyFrameworkDefaults.

To test:
1. Set the system preference ApplyFrameworkDefaults - Select All
2. Create or edit a MARC bibliographic framework with a default value in
   one of the fields (such as 500$a)
3. Go to the Cataloguing module and create a new record using the
   framework from step 2
   --> Confirm that the default value is filled in
4. Search for an existing bib record
5. Click Edit > Edit record to open the basic editor
6. If the field from step 2 already has data, clear it
7. Switch the framework to the framework from step 2
   --> Confirm that the default value is filled in
8. Clear the field again, and save the edit
9. Click Edit > Edit as new (duplicate)
   --> Confirm that the default value is filled in
10. Go to the cataloguing module and do a Z39.50 search
11. Find a record that does not have a value for the subfield from step 2
12. Import the record using the framework from step 2
    --> Confirm that the default value is filled in

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Created attachment 158461 [details] [review]
Bug 34993: (QA follow-up) Perltidy

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Thanks a lot Emily for fixing this one!

Pushed to master for 23.11.

Nice work everyone, thanks!

*** Bug 35289 has been marked as a duplicate of this bug. ***

Will it be backported to 22.11 or 23.05?

(In reply to Lauren Denny from comment #16)
> Will it be backported to 22.11 or 23.05?

Bugs marked major that are in lower versions usually are backported. But the RMaint always makes the last decision.

Pushed to 23.05.x for 23.05.06

Nice work everyone!

Pushed to 22.11.x for next release