Summary: | Configure self checkout tables consistently | ||
---|---|---|---|
Product: | Koha | Reporter: | David Nind <david> |
Component: | Self checkout | Assignee: | Owen Leonard <oleonard> |
Status: | Needs documenting --- | QA Contact: | Nick Clemens (kidclamp) <nick> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers, nick, phil, tomascohen |
Version: | Main | Keywords: | Academy |
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.11.00
|
|
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 37027 | ||
Attachments: |
Screenshot showing DataTables controls
Bug 35007: Configure self checkout tables consistently Bug 35007: Configure self checkout tables consistently Bug 35007: Configure self checkout tables consistently Bug 35007: Configure self checkout tables consistently |
Description
David Nind
2023-10-08 18:51:14 UTC
Created attachment 156754 [details]
Screenshot showing DataTables controls
The table style differences on this page are due to the fact that the checkouts table is a DataTable and the others are not. We could modify the CSS so that they match, but I think we might like to make the holds and account tables DataTables.
Since I'm copying DT initialization from opac-user.tt I wonder: Should we include copy/csv/print buttons like we do on that page? See attached screenshot.
(In reply to Owen Leonard from comment #1) > > Since I'm copying DT initialization from opac-user.tt I wonder: Should we > include copy/csv/print buttons like we do on that page? See attached > screenshot. It wouldn't hurt, but I'm not sure whether a patron would use them - but you never know! Created attachment 156803 [details] [review] Bug 35007: Configure self checkout tables consistently This patch makes some updates to the self checkout page so that checkouts, holds, and account tabs are consistent with each other, with the same DataTables configuration. Included in the DataTables configuration are the same options we use on the OPAC's user summary page to show controls for copy, CSV, and print. Also changed: Some extra markup is removed from holds-table.inc, markup which was used to show table information responsively before we started using the DataTables responsive plugin. To test, apply the patch and log into the self checkout system as a user with checkouts, holds, and present or past charges. Compare the checkouts, holds, and charges tabs to confirm that the tables look correct and work correctly. Test that the copy, CSV, and print controls, and the search and clear filter functions. Test that each table responds correctly at various browser widths. Created attachment 156805 [details] [review] Bug 35007: Configure self checkout tables consistently This patch makes some updates to the self checkout page so that checkouts, holds, and account tabs are consistent with each other, with the same DataTables configuration. Included in the DataTables configuration are the same options we use on the OPAC's user summary page to show controls for copy, CSV, and print. Also changed: Some extra markup is removed from holds-table.inc, markup which was used to show table information responsively before we started using the DataTables responsive plugin. To test, apply the patch and log into the self checkout system as a user with checkouts, holds, and present or past charges. Compare the checkouts, holds, and charges tabs to confirm that the tables look correct and work correctly. Test that the copy, CSV, and print controls, and the search and clear filter functions. Test that each table responds correctly at various browser widths. Signed-off-by: David Nind <david@davidnind.com> Thanks Owen! Created attachment 156874 [details] [review] Bug 35007: Configure self checkout tables consistently This patch makes some updates to the self checkout page so that checkouts, holds, and account tabs are consistent with each other, with the same DataTables configuration. Included in the DataTables configuration are the same options we use on the OPAC's user summary page to show controls for copy, CSV, and print. Also changed: Some extra markup is removed from holds-table.inc, markup which was used to show table information responsively before we started using the DataTables responsive plugin. To test, apply the patch and log into the self checkout system as a user with checkouts, holds, and present or past charges. Compare the checkouts, holds, and charges tabs to confirm that the tables look correct and work correctly. Test that the copy, CSV, and print controls, and the search and clear filter functions. Test that each table responds correctly at various browser widths. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> We may want a way to easily hide the table controls, not sure if there is a simple CSS, but some libraries won't have a printer hooked up, or the table might not print nice to a receipt printer, but I don't think including by default hurts Please rebase ASAP. Thanks! Created attachment 157794 [details] [review] Bug 35007: Configure self checkout tables consistently This patch makes some updates to the self checkout page so that checkouts, holds, and account tabs are consistent with each other, with the same DataTables configuration. Included in the DataTables configuration are the same options we use on the OPAC's user summary page to show controls for copy, CSV, and print. Also changed: Some extra markup is removed from holds-table.inc, markup which was used to show table information responsively before we started using the DataTables responsive plugin. To test, apply the patch and log into the self checkout system as a user with checkouts, holds, and present or past charges. Compare the checkouts, holds, and charges tabs to confirm that the tables look correct and work correctly. Test that the copy, CSV, and print controls, and the search and clear filter functions. Test that each table responds correctly at various browser widths. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to master for 23.11. Nice work everyone, thanks! Conflicts when backport 23.05.x on : koha-tmpl/opac-tmpl/bootstrap/en/includes/holds-table.inc koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt Please create a dedicated patch if backport is wanted. (In reply to Nick Clemens from comment #7) > We may want a way to easily hide the table controls, not sure if there is a > simple CSS Putting this in SCOUserCSS seems to work: .buttons-copy, .buttons-csv, .buttons-print { display: none; } or if you don't want the search filter either: .table_controls { display: none; } |