Summary: | Times should only be set for enable-time flatpickrs | ||
---|---|---|---|
Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
Component: | Architecture, internals, and plumbing | Assignee: | Martin Renvoize (ashimema) <martin.renvoize> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | major | ||
Priority: | P5 - low | CC: | fridolin.somers, lucas |
Version: | Main | Keywords: | rel_23_11_candidate |
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
23.11.00,23.05.05,22.11.11
|
Circulation function: | |
Bug Depends on: | 34939 | ||
Bug Blocks: | |||
Attachments: |
Bug 35014: Only set time for enable-time flatpickr
Bug 35014: Only set time for enable-time flatpickr Bug 35014: Only set time for enable-time flatpickr |
Description
Martin Renvoize (ashimema)
2023-10-09 15:35:51 UTC
Created attachment 156750 [details] [review] Bug 35014: Only set time for enable-time flatpickr This patch adds a check to the onChange function such that we only attempt to set the default time on change for time enabled flatpickrs when the date is entered manually. Created attachment 156753 [details] [review] Bug 35014: Only set time for enable-time flatpickr This patch adds a check to the onChange function such that we only attempt to set the default time on change for time enabled flatpickrs when the date is entered manually. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 156767 [details] [review] Bug 35014: Only set time for enable-time flatpickr This patch adds a check to the onChange function such that we only attempt to set the default time on change for time enabled flatpickrs when the date is entered manually. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.11. Nice work everyone, thanks! Strange to see Bug 34539 as dependancy since it is NEW Can this be backported ? Hmm, I thought I'd removed that dependency.. it was a typo on my part when first opening the bug.. I suspect a bugzilla conflict put it back again. Pushed to 23.05.x for 23.05.05 Nice work everyone! Pushed to oldstable for 22.11.x |