Bug 35015

Summary: Regression: Charges table no longer filters out paid transactions
Product: Koha Reporter: Matt Blenkinsop <matt.blenkinsop>
Component: Fines and feesAssignee: Matt Blenkinsop <matt.blenkinsop>
Status: Pushed to oldstable --- QA Contact: Katrin Fischer <katrin.fischer>
Severity: major    
Priority: P5 - low CC: fridolin.somers
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.05,22.11.11
Bug Depends on: 32341    
Bug Blocks:    
Attachments: Bug 35015: Adjust column index in fnFilter
Bug 35015: Adjust column index in fnFilter
Bug 35015: Adjust column index in fnFilter
Bug 35015: Adjust column index in fnFilter
Bug 35015: (QA follow-up) Fix paid transactions filter in the staff interface
Bug 35015: (QA follow-up) Fix paid transactions filter in the staff interface

Description Matt Blenkinsop 2023-10-09 16:10:44 UTC
Bug 32431 has introduced a blank column to help with responsiveness but this has broken the filtering as it is column index based. The column index needs adjusting to account for this.
Comment 1 Matt Blenkinsop 2023-10-09 16:15:51 UTC
Created attachment 156755 [details] [review]
Bug 35015: Adjust column index in fnFilter

This patch fixes the column index in the call to fnFilter following the addition of a new column to the table in bug 32341

Test plan:
1) Add some charges to a patron account
2) Pay some of these charges so that they are no longer outstanding
3) In the OPAC log in as that patron and navigate to the Charges tab in their account
4) Observe that all charges are listed, even if they have been paid and clicking the Show all transactions button has no effect even if clicked multiple times between the different filtering options
5) Apply patch
6) Refresh page and now the settled charges should be filtered out
7) Click the Show all transactions button and it should correctly update
Comment 2 Owen Leonard 2023-10-09 16:38:01 UTC
Created attachment 156756 [details] [review]
Bug 35015: Adjust column index in fnFilter

This patch fixes the column index in the call to fnFilter following the
addition of a new column to the table in bug 32341

Test plan:
1) Add some charges to a patron account
2) Pay some of these charges so that they are no longer outstanding
3) In the OPAC log in as that patron and navigate to the Charges tab in
   their account
4) Observe that all charges are listed, even if they have been paid and
   clicking the Show all transactions button has no effect even if
   clicked multiple times between the different filtering options
5) Apply patch
6) Refresh page and now the settled charges should be filtered out
7) Click the Show all transactions button and it should correctly update

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Katrin Fischer 2023-10-09 19:54:37 UTC
Created attachment 156764 [details] [review]
Bug 35015: Adjust column index in fnFilter

This patch fixes the column index in the call to fnFilter following the
addition of a new column to the table in bug 32341

Test plan:
1) Add some charges to a patron account
2) Pay some of these charges so that they are no longer outstanding
3) In the OPAC log in as that patron and navigate to the Charges tab in
   their account
4) Observe that all charges are listed, even if they have been paid and
   clicking the Show all transactions button has no effect even if
   clicked multiple times between the different filtering options
5) Apply patch
6) Refresh page and now the settled charges should be filtered out
7) Click the Show all transactions button and it should correctly update

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Katrin Fischer 2023-10-09 20:00:40 UTC
Created attachment 156765 [details] [review]
Bug 35015: Adjust column index in fnFilter

This patch fixes the column index in the call to fnFilter following the
addition of a new column to the table in bug 32341

Test plan:
1) Add some charges to a patron account
2) Pay some of these charges so that they are no longer outstanding
3) In the OPAC log in as that patron and navigate to the Charges tab in
   their account
4) Observe that all charges are listed, even if they have been paid and
   clicking the Show all transactions button has no effect even if
   clicked multiple times between the different filtering options
5) Apply patch
6) Refresh page and now the settled charges should be filtered out
7) Click the Show all transactions button and it should correctly update

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Katrin Fischer 2023-10-09 20:00:43 UTC
Created attachment 156766 [details] [review]
Bug 35015: (QA follow-up) Fix paid transactions filter in the staff interface

Same problem: we added a column without adjusting the filter.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Owen Leonard 2023-10-10 10:34:00 UTC
Created attachment 156784 [details] [review]
Bug 35015: (QA follow-up) Fix paid transactions filter in the staff interface

Same problem: we added a column without adjusting the filter.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 7 Tomás Cohen Arazi 2023-10-10 12:23:19 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 8 Fridolin Somers 2023-10-12 20:46:54 UTC
Pushed to 23.05.x for 23.05.05
Comment 9 Matt Blenkinsop 2023-10-17 17:36:28 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x