Summary: | If creating items when ordering, an alert should appear if the item type is not filled out | ||
---|---|---|---|
Product: | Koha | Reporter: | Kelly McElligott <kelly> |
Component: | Acquisitions | Assignee: | Bugs List <koha-bugs> |
Status: | NEW --- | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | caroline.cyr-la-rose, dch, jzairo |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: |
Description
Kelly McElligott
2023-10-10 13:40:31 UTC
HI Kelly, the itemtype should always be made mandatory in the ACQ framework and then trigger when it's not filled in. But this was broken a little while ago, maybe you are on a broken version still? Bug 34109 - When adding items on receive, mandatory fields are not checked Or it#s maybe not set to be mandatory? It should be, otherwise those items break the OPAC detail view. itemtype is set to mandatory for all new installations now (but was not in the past) I just had this in a client installation. They had made the item type not mandatory in ACQ framework. I don't think it caused an error before since they never complained until we upgraded them to 23.05. I told them to make it mandatory again and batch modify the items that have itype is null. Maybe we could disable the mandatory checkbox for the field mapped to item type? Or make it not explode if the item type is null. Cait also suggested adding the check in the framework test, which could be an in between, but won't prevent errors. Now that we are checking for item type throughout Koha, we should remove the option to untick the Mandatory box from all frameworks. If you cannot create an item without an item type, it will eliminate a lot of 'Error 500' messages |