| Summary: | Remove the use of "onclick" from Koha to MARC mapping template | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | System Administration | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | andrew, fridolin.somers, gmcharlt, testopia |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| URL: | /cgi-bin/koha/admin/koha2marclinks.pl | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.11.00
|
|
| Circulation function: | |||
| Attachments: |
Bug 35032: Remove the use of "onclick" from Koha to MARC mapping template
Bug 35032: Remove the use of "onclick" from Koha to MARC mapping template Bug 35032: Remove the use of "onclick" from Koha to MARC mapping template |
||
|
Description
Owen Leonard
2023-10-11 15:40:48 UTC
Created attachment 156851 [details] [review] Bug 35032: Remove the use of "onclick" from Koha to MARC mapping template This patch eliminates two instances of "onclick" from the Koha to MARC mapping template, moving these event handlers into JS in the footer. To test, apply the patch and go to Administration -> Koha to MARC mapping. - Click "Add" next to a Koha field. - You should get a JS popup asking for entry of a MARC tag. Confirm that this process completes correctly. - Test a "Remove" link too. It should work to remove mapping from a Koha field. - Test the "Cancel" choice in both the "Add" and "Remove" cases to confirm that the operation is cancelled. Created attachment 156877 [details] [review] Bug 35032: Remove the use of "onclick" from Koha to MARC mapping template This patch eliminates two instances of "onclick" from the Koha to MARC mapping template, moving these event handlers into JS in the footer. To test, apply the patch and go to Administration -> Koha to MARC mapping. - Click "Add" next to a Koha field. - You should get a JS popup asking for entry of a MARC tag. Confirm that this process completes correctly. - Test a "Remove" link too. It should work to remove mapping from a Koha field. - Test the "Cancel" choice in both the "Add" and "Remove" cases to confirm that the operation is cancelled. Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Created attachment 156988 [details] [review] Bug 35032: Remove the use of "onclick" from Koha to MARC mapping template This patch eliminates two instances of "onclick" from the Koha to MARC mapping template, moving these event handlers into JS in the footer. To test, apply the patch and go to Administration -> Koha to MARC mapping. - Click "Add" next to a Koha field. - You should get a JS popup asking for entry of a MARC tag. Confirm that this process completes correctly. - Test a "Remove" link too. It should work to remove mapping from a Koha field. - Test the "Cancel" choice in both the "Add" and "Remove" cases to confirm that the operation is cancelled. Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to master for 23.11. Nice work everyone, thanks! Does not apply easy on 23.05.x It is minor so I skip. |