Summary: | Incorrect chopping to punctuation in 246 fields | ||
---|---|---|---|
Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
Component: | MARC Bibliographic data support | Assignee: | Lucas Gass (lukeg) <lucas> |
Status: | Failed QA --- | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | ||
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24833 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 35036: Do not remove punctuaction of 246 fields
Bug 35036: Do not remove punctuaction of 246 fields Bug 35036: Remove extra puncuation from staff results page Bug 35036: Do not remove punctuaction of 246 fields Bug 35036: Remove extra puncuation from staff results page Bug 35036: Remove extra puncuation from staff results page |
Description
Lucas Gass (lukeg)
2023-10-11 16:41:03 UTC
I meant 246$b, not 245. Created attachment 156881 [details] [review] Bug 35036: Do not remove punctuaction of 246 fields Created attachment 156882 [details] [review] Bug 35036: Do not remove punctuaction of 246 fields To test: 1. Add a 245$b to a record that ends with punctuation. ie. 'E.B.' 2. Go the record detail page on both the staff interface and OPAC. 3. The last period does not display. 4. APPLY patch and restart services 5. Look at the OPAC detail and staff interface detail pages again, the display should include punctuation Created attachment 156883 [details] [review] Bug 35036: Remove extra puncuation from staff results page To test: 1. Look at the a results set on the staff interface that contains titles with a 246. 2. It now contains too much puncuation. 3. Apply patch 4. It now looks like the other pages. Created attachment 156986 [details] [review] Bug 35036: Do not remove punctuaction of 246 fields To test: 1. Add a 245$b to a record that ends with punctuation. ie. 'E.B.' 2. Go the record detail page on both the staff interface and OPAC. 3. The last period does not display. 4. APPLY patch and restart services 5. Look at the OPAC detail and staff interface detail pages again, the display should include punctuation Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Created attachment 156987 [details] [review] Bug 35036: Remove extra puncuation from staff results page To test: 1. Look at the a results set on the staff interface that contains titles with a 246. 2. It now contains too much puncuation. 3. Apply patch 4. It now looks like the other pages. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Created attachment 156991 [details] [review] Bug 35036: Remove extra puncuation from staff results page To test: 1. Look at the a results set on the staff interface that contains titles with a 246. 2. It now contains too much puncuation. 3. Apply patch 4. It now looks like the other pages. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Esther <esther@bywatersolutions.com> There are some issues with this this patch set: * If a library does the ending . at the end of fields, it will now keep showing. As we always always remove it, that will be inconsistent. The chop punctuation is thought to remove that ending dot, but the problem is that we cannot distinguish between an abbreviation dot and the field ending punctuation. This is not only a problem for 246, it's a general known issue. * Removing the common separator | on the staff results page doesn't give the expected result (missing space at least, but also no longer consistent) Other title: TitleA : RemainderA.TitleB : RamainderB. I think if we want to change this, we need to find a general solution and apply it to more than only the 246 field. I believe this needs more thought. This is not only a problem for 246, it's a general known
> issue.
Is there an open bug for the general issue?
> I think if we want to change this, we need to find a general solution and
> apply it to more than only the 246 field. I believe this needs more thought.
Can we at least make the logic behind the displaying of the 246 consistent for staff detail/results and OPAC detail/results?
Right now we do something different in each of the 4 XSLT files.
(In reply to Lucas Gass from comment #9) > This is not only a problem for 246, it's a general known > > issue. > > Is there an open bug for the general issue? I already linked it: bug 24833 Sorry I that came across kind of harsh before - of course I think consistency would be good. |