Description
Owen Leonard
2023-10-13 12:32:42 UTC
Created attachment 157104 [details] [review] Bug 35048: Convert SCOMainUserBlock system preference to HTML customization This patch moves the SCOMainUserBlock system preference into HTML customizations, making it possible to have language- and library-specific content. The patch also makes a minor fix to CSS in order to get the "Back to top" link to show up correctly in self-checkout and self-checkin. To test you should have some content in the SCOMainUserBlock system preference before applying the patch. Apply the patch, run the database update process, and rebuild the OPAC CSS. - In the staff client, go to Tools -> HTML customizations and verify that the content from SCOMainUserBlock is now stored there. - The HTML customization entry form should offer SCOMainUserBlock as a choice under "Display location." - Update and reinstall active translations (for instance fr-FR): - perl misc/translator/translate update fr-FR - perl misc/translator/translate install fr-FR - Enable the translation if necessary under Administration -> System preferences -> language. - Enable the "opaclanguagesdisplay" preference if necessary. - Edit the SCOMainUserBlock HTML customization and add unique content to the "fr-FR" tab. - Log into the self checkout system and confirm that the SCOMainUserBlock content is shown there. - Switch to your updated translation and confirm that the content you added for your translation shows up correctly. - Go to Administration -> System preferences and search for "SCOMainUserBlock." It should return no results. Created attachment 157105 [details] [review] Bug 35048: Convert SCOMainUserBlock system preference to HTML customization This patch moves the SCOMainUserBlock system preference into HTML customizations, making it possible to have language- and library-specific content. The patch also makes a minor fix to CSS in order to get the "Back to top" link to show up correctly in self-checkout and self-checkin. To test you should have some content in the SCOMainUserBlock system preference before applying the patch. Apply the patch, run the database update process, and rebuild the OPAC CSS. - In the staff client, go to Tools -> HTML customizations and verify that the content from SCOMainUserBlock is now stored there. - The HTML customization entry form should offer SCOMainUserBlock as a choice under "Display location." - Update and reinstall active translations (for instance fr-FR): - perl misc/translator/translate update fr-FR - perl misc/translator/translate install fr-FR - Enable the translation if necessary under Administration -> System preferences -> language. - Enable the "opaclanguagesdisplay" preference if necessary. - Edit the SCOMainUserBlock HTML customization and add unique content to the "fr-FR" tab. - Log into the self checkout system and confirm that the SCOMainUserBlock content is shown there. - Switch to your updated translation and confirm that the content you added for your translation shows up correctly. - Go to Administration -> System preferences and search for "SCOMainUserBlock." It should return no results. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 157559 [details] [review] Bug 35048: Convert SCOMainUserBlock system preference to HTML customization This patch moves the SCOMainUserBlock system preference into HTML customizations, making it possible to have language- and library-specific content. The patch also makes a minor fix to CSS in order to get the "Back to top" link to show up correctly in self-checkout and self-checkin. To test you should have some content in the SCOMainUserBlock system preference before applying the patch. Apply the patch, run the database update process, and rebuild the OPAC CSS. - In the staff client, go to Tools -> HTML customizations and verify that the content from SCOMainUserBlock is now stored there. - The HTML customization entry form should offer SCOMainUserBlock as a choice under "Display location." - Update and reinstall active translations (for instance fr-FR): - perl misc/translator/translate update fr-FR - perl misc/translator/translate install fr-FR - Enable the translation if necessary under Administration -> System preferences -> language. - Enable the "opaclanguagesdisplay" preference if necessary. - Edit the SCOMainUserBlock HTML customization and add unique content to the "fr-FR" tab. - Log into the self checkout system and confirm that the SCOMainUserBlock content is shown there. - Switch to your updated translation and confirm that the content you added for your translation shows up correctly. - Go to Administration -> System preferences and search for "SCOMainUserBlock." It should return no results. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Hi Owen, can you please also adjust this one for 31383? Created attachment 157831 [details] [review] Bug 35048: Convert SCOMainUserBlock system preference to HTML customization This patch moves the SCOMainUserBlock system preference into HTML customizations, making it possible to have language- and library-specific content. The patch also makes a minor fix to CSS in order to get the "Back to top" link to show up correctly in self-checkout and self-checkin. To test you should have some content in the SCOMainUserBlock system preference before applying the patch. Apply the patch, run the database update process, and rebuild the OPAC CSS. - In the staff client, go to Tools -> HTML customizations and verify that the content from SCOMainUserBlock is now stored there. - The HTML customization entry form should offer SCOMainUserBlock as a choice under "Display location." - Update and reinstall active translations (for instance fr-FR): - perl misc/translator/translate update fr-FR - perl misc/translator/translate install fr-FR - Enable the translation if necessary under Administration -> System preferences -> language. - Enable the "opaclanguagesdisplay" preference if necessary. - Edit the SCOMainUserBlock HTML customization and add unique content to the "fr-FR" tab. - Log into the self checkout system and confirm that the SCOMainUserBlock content is shown there. - Switch to your updated translation and confirm that the content you added for your translation shows up correctly. - Go to Administration -> System preferences and search for "SCOMainUserBlock." It should return no results. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 157832 [details] [review] Bug 35048: (follow-up) Add entry to HTML customization help include Created attachment 157918 [details] [review] Bug 35048: Convert SCOMainUserBlock system preference to HTML customization This patch moves the SCOMainUserBlock system preference into HTML customizations, making it possible to have language- and library-specific content. The patch also makes a minor fix to CSS in order to get the "Back to top" link to show up correctly in self-checkout and self-checkin. To test you should have some content in the SCOMainUserBlock system preference before applying the patch. Apply the patch, run the database update process, and rebuild the OPAC CSS. - In the staff client, go to Tools -> HTML customizations and verify that the content from SCOMainUserBlock is now stored there. - The HTML customization entry form should offer SCOMainUserBlock as a choice under "Display location." - Update and reinstall active translations (for instance fr-FR): - perl misc/translator/translate update fr-FR - perl misc/translator/translate install fr-FR - Enable the translation if necessary under Administration -> System preferences -> language. - Enable the "opaclanguagesdisplay" preference if necessary. - Edit the SCOMainUserBlock HTML customization and add unique content to the "fr-FR" tab. - Log into the self checkout system and confirm that the SCOMainUserBlock content is shown there. - Switch to your updated translation and confirm that the content you added for your translation shows up correctly. - Go to Administration -> System preferences and search for "SCOMainUserBlock." It should return no results. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 157919 [details] [review] Bug 35048: (follow-up) Add entry to HTML customization help include Created attachment 158453 [details] [review] Bug 35048: Convert SCOMainUserBlock system preference to HTML customization This patch moves the SCOMainUserBlock system preference into HTML customizations, making it possible to have language- and library-specific content. The patch also makes a minor fix to CSS in order to get the "Back to top" link to show up correctly in self-checkout and self-checkin. To test you should have some content in the SCOMainUserBlock system preference before applying the patch. Apply the patch, run the database update process, and rebuild the OPAC CSS. - In the staff client, go to Tools -> HTML customizations and verify that the content from SCOMainUserBlock is now stored there. - The HTML customization entry form should offer SCOMainUserBlock as a choice under "Display location." - Update and reinstall active translations (for instance fr-FR): - perl misc/translator/translate update fr-FR - perl misc/translator/translate install fr-FR - Enable the translation if necessary under Administration -> System preferences -> language. - Enable the "opaclanguagesdisplay" preference if necessary. - Edit the SCOMainUserBlock HTML customization and add unique content to the "fr-FR" tab. - Log into the self checkout system and confirm that the SCOMainUserBlock content is shown there. - Switch to your updated translation and confirm that the content you added for your translation shows up correctly. - Go to Administration -> System preferences and search for "SCOMainUserBlock." It should return no results. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 158454 [details] [review] Bug 35048: (follow-up) Add entry to HTML customization help include Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> This doubled up "the" is fixed by the next patch in the series: +<div id="SCOMainUserBlock_notes" class="hint customization_note"> + Show this content on the the web-based self checkout screen. +</div> + Applying: Bug 35048: Convert SCOMainUserBlock system preference to HTML customization error: sha1 information is lacking or useless (installer/data/mysql/mandatory/sysprefs.sql). error: could not build fake ancestor Patch failed at 0001 Bug 35048: Convert SCOMainUserBlock system preference to HTML customization hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /var/folders/c9/kzgdqlvn38q3v1gs59cjhzrw0000gn/T/Bug-35048-Convert-SCOMainUserBlock-system-preferen-8vmn73_f.patch Created attachment 158722 [details] [review] Bug 35048: Convert SCOMainUserBlock system preference to HTML customization This patch moves the SCOMainUserBlock system preference into HTML customizations, making it possible to have language- and library-specific content. The patch also makes a minor fix to CSS in order to get the "Back to top" link to show up correctly in self-checkout and self-checkin. To test you should have some content in the SCOMainUserBlock system preference before applying the patch. Apply the patch, run the database update process, and rebuild the OPAC CSS. - In the staff client, go to Tools -> HTML customizations and verify that the content from SCOMainUserBlock is now stored there. - The HTML customization entry form should offer SCOMainUserBlock as a choice under "Display location." - Update and reinstall active translations (for instance fr-FR): - perl misc/translator/translate update fr-FR - perl misc/translator/translate install fr-FR - Enable the translation if necessary under Administration -> System preferences -> language. - Enable the "opaclanguagesdisplay" preference if necessary. - Edit the SCOMainUserBlock HTML customization and add unique content to the "fr-FR" tab. - Log into the self checkout system and confirm that the SCOMainUserBlock content is shown there. - Switch to your updated translation and confirm that the content you added for your translation shows up correctly. - Go to Administration -> System preferences and search for "SCOMainUserBlock." It should return no results. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 158723 [details] [review] Bug 35048: (follow-up) Add entry to HTML customization help include Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 158724 [details] [review] Bug 35048: (follow-up) Atomic update fixes Pushed to master for 23.11. Nice work everyone, thanks! Enhancement not pushed to 23.05.x |