| Summary: | Items needed column on circ/reserveratios.pl does not sort properly | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
| Component: | Hold requests | Assignee: | Lucas Gass (lukeg) <lucas> |
| Status: | CLOSED FIXED | QA Contact: | Emily Lamancusa (emlam) <emily.lamancusa> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | emily.lamancusa, felicity.brown, fridolin.somers, gmcharlt, martin.renvoize, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.11.00,23.05.05,22.11.12
|
|
| Circulation function: | |||
| Attachments: |
Bug 35069: Fix holds to buy column sorting
Bug 35069: Fix hold ratios items needed column sorting Bug 35069: Fix hold ratios items needed column sorting |
||
|
Description
Lucas Gass (lukeg)
2023-10-16 23:02:13 UTC
Created attachment 157219 [details] [review] Bug 35069: Fix holds to buy column sorting This patch adds the data-sort attribute to the "Items to buy" column to ensure proper sorting. To test: 1. Make a lot of holds. 2. On some holds have a high enough holds/copies ratio so the "Items to buy column" has values greater than 10. 3. Sort by that column. Notice the copies with an "Items to buy" higher than 10 do not get sorted correctly. 4. APPLY PATCH 5. Try steps 1 -3 again. Everything should sort properly. Created attachment 157225 [details] [review] Bug 35069: Fix hold ratios items needed column sorting This patch adds the data-sort attribute to the "Items needed" column to ensure proper sorting. To test: 1. Make a lot of holds. 2. On some holds have a high enough holds/copies ratio so the "Items needed" has values greater than 10. 3. Sort by that column. Notice the copies with an "Items needed" higher than 10 do not get sorted correctly. 4. APPLY PATCH 5. Try steps 1 -3 again. Everything should sort properly. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 157287 [details] [review] Bug 35069: Fix hold ratios items needed column sorting This patch adds the data-sort attribute to the "Items needed" column to ensure proper sorting. To test: 1. Make a lot of holds. 2. On some holds have a high enough holds/copies ratio so the "Items needed" has values greater than 10. 3. Sort by that column. Notice the copies with an "Items needed" higher than 10 do not get sorted correctly. 4. APPLY PATCH 5. Try steps 1 -3 again. Everything should sort properly. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Pushed to master for 23.11. Nice work everyone, thanks! Pushed to 23.05.x for 23.05.05 Nice work everyone! Pushed to oldstable for 22.11.x |